Improve the message when run coverage while there are no tests #6334

rhysawilliams2010 · 2018-05-29T02:45:08Z

Resolves #6141

Summary

I wanted to be able to have a global threshold group (for any new files) even though I have path and glob threshold groups for all the existing files in my project.

At the moment, if you have a global threshold and glob or path matchers for all the files in the coverage data, jest throws an exception: Jest: Coverage data for global was not found.

I also wanted to be able to have a file be matched by more than one path or glob threshold group. So I can target specific file paths with precise thresholds but still have those files included in a path threshold group targeting the file's directory.

I updated the coverage reporting so that it still conforms to the
documentation but doesn't throw an error when there are no files matching
"global" threshold group (maybe because they are already matched with a path or glob).
I also made sure that a file is matched against all matching path and glob threshold groups instead of just one.

Test plan

SimenB · 2018-05-29T07:11:59Z

packages/jest-cli/src/reporters/__tests__/coverage_reporter.test.js

+        const file = path.resolve(f[0]);
+        const override = f[1];
+        c[file] = new CoverageSummary({
+          ...covSummary,


Please use Object.assign

SimenB · 2018-05-29T08:34:53Z

@aaronabramov coverage collection is still pretty magical to me, does this change make sense?

codecov-io · 2018-05-29T08:47:35Z

Codecov Report

Merging #6334 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6334      +/-   ##
==========================================
+ Coverage   63.55%   63.56%   +<.01%     
==========================================
  Files         235      235              
  Lines        9030     9032       +2     
  Branches        3        4       +1     
==========================================
+ Hits         5739     5741       +2     
  Misses       3290     3290              
  Partials        1        1

Impacted Files	Coverage Δ
...ckages/jest-cli/src/reporters/coverage_reporter.js	`66.92% <100%> (+0.52%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0591f22...66798eb. Read the comment docs.

SimenB · 2018-05-29T09:02:02Z

packages/jest-cli/src/reporters/__tests__/coverage_reporter.test.js

@@ -16,6 +16,7 @@ let libSourceMaps;
 let CoverageReporter;
 let istanbulApi;

+import {CoverageSummary} from 'istanbul-lib-coverage/lib/file';


is it supported to do a deep import like this?

better way would be to use public createCoverageSummary api
https://github.com/istanbuljs/istanbuljs/blob/master/packages/istanbul-lib-coverage/index.js#L26-L31

aaronabramov

i'm actually really struggling to understand what's going on here :)
having an e2e test for this would be amazing

aaronabramov · 2018-05-29T13:46:44Z

packages/jest-cli/src/reporters/__tests__/coverage_reporter.test.js

@@ -16,6 +16,7 @@ let libSourceMaps;
 let CoverageReporter;
 let istanbulApi;

+import {CoverageSummary} from 'istanbul-lib-coverage/lib/file';


better way would be to use public createCoverageSummary api
https://github.com/istanbuljs/istanbuljs/blob/master/packages/istanbul-lib-coverage/index.js#L26-L31

SimenB · 2018-05-29T14:33:58Z

An e2e test would be great, yeah. Can probably extend https://github.com/facebook/jest/tree/master/e2e/coverage-report to encompass the fix here. Or use it as basis to setup a new dedicated e2e test

rhysawilliams2010 · 2018-05-29T21:54:43Z

@SimenB is this the test I should add to?

fixes jestjs#6141 Update the coverage reporting so that it still conforms to the documentation but doesn't throw an error when there are no files matching "global" threshold group (maybe because they are already matched with a path or glob). Also make sure that a file is matched against all matching path and glob threshold groups instead of just one.

(instead of the whole module). So that I can use the original createCoverageSummary function to create test data.

SimenB · 2018-05-30T06:06:34Z

Yeah, that seems reasonable! 🙂

I added snapshots for stderr so that I could test the Jest errors raised for each failed threshold group.

…ge-no-tests-warning

stderr snapshots. Do a replace on the stderr which has a full path to a failed glob threshold file which won't match when the test runs on windows (appveyor)

thymikee · 2018-07-07T17:30:54Z

@aaronabramov might taking a look once again? Test was added :)

aaronabramov

yeah! e2e describes what happened much better :)

* upstream/master: (122 commits) fix: don't report promises as open handles (jestjs#6716) support serializing `DocumentFragment` (jestjs#6705) Allow test titles to include array index (jestjs#6414) fix `toContain` suggest to contain equal message (jestjs#6810) fix: testMatch not working with negations (jestjs#6648) Add test cases for jestjs#6744 (jestjs#6772) print stack trace on calls to process.exit (jestjs#6714) Updates SnapshotTesting.md to provide more info. on snapshot scope (jestjs#6735) Mark snapshots as obsolete when moved to an inline snapshot (jestjs#6773) [Docs] Clarified the use of literal values as property matchers in toMatchSnapshot() (jestjs#6807) Update CHANGELOG.md (jestjs#6799) fix changelog entry that is not in 23.4.2 (jestjs#6796) Fix --coverage with --findRelatedTests overwriting collectCoverageFrom options (jestjs#6736) Update testURL default value from about:blank to localhost (jestjs#6792) fix: `matchInlineSnapshot` when prettier dependencies are mocked (jestjs#6776) Fix retryTimes and add e2e regression test (jestjs#6762) Release v23.4.2 Docs/ExpectAPI: Correct docs for `objectContaining` (jestjs#6754) chore(packages/babel-jest) readme (jestjs#6746) docs: noted --coverage aliased by --collectCoverage (jestjs#6741) ...

github-actions · 2021-05-12T10:07:27Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

facebook-github-bot added the cla signed label May 29, 2018

rhysawilliams2010 force-pushed the coverage-no-tests-warning branch 2 times, most recently from d7b3765 to 12e2f38 Compare May 29, 2018 03:27

SimenB reviewed May 29, 2018

View reviewed changes

SimenB approved these changes May 29, 2018

View reviewed changes

SimenB reviewed May 29, 2018

View reviewed changes

aaronabramov reviewed May 29, 2018

View reviewed changes

rhysawilliams2010 force-pushed the coverage-no-tests-warning branch from 3baf41a to 6305bfc Compare May 29, 2018 21:47

rhys williams added 3 commits May 30, 2018 10:21

use Object.assign

94f2331

Only mock specific functions exported by istanbul-lib-coverage

71b829e

(instead of the whole module). So that I can use the original createCoverageSummary function to create test data.

rhysawilliams2010 force-pushed the coverage-no-tests-warning branch from 6305bfc to 71b829e Compare May 29, 2018 22:22

rhys williams and others added 7 commits May 31, 2018 10:56

Add e2e tests for coverage threshold.

271b542

I added snapshots for stderr so that I could test the Jest errors raised for each failed threshold group.

Merge branch 'master' into coverage-no-tests-warning

c4e749b

revert unnecessary test changes

f4b160b

linting

bf81a29

Replace process.cwd() in stderr snapshot test.

b62e3df

Merge branch 'master' of https://github.com/facebook/jest into covera…

3c36107

…ge-no-tests-warning

Make the tests more robust by using extractSummary method to compare

68a822b

stderr snapshots. Do a replace on the stderr which has a full path to a failed glob threshold file which won't match when the test runs on windows (appveyor)

aaronabramov approved these changes Jul 9, 2018

View reviewed changes

thymikee added 3 commits August 8, 2018 22:26

move changelog entry

66798eb

Merge branch 'master' into coverage-no-tests-warning

c8b2189

thymikee merged commit 08cb885 into jestjs:master Aug 9, 2018

This was referenced Oct 1, 2018

Update jest in /modules/api from 22.4.3 to 23.6.0 project-accelerate/accelerate#245

Open

Update jest in /modules/frontend from 22.4.3 to 23.6.0 project-accelerate/accelerate#272

Open

dependencies bot mentioned this pull request Nov 1, 2018

Update jest in / from 22.1.4 to 23.6.0 leonardofaria/leozera-ui#250

Closed

snyk-bot mentioned this pull request Mar 17, 2020

[Snyk] Upgrade expect from 23.0.0 to 23.6.0 yowainwright/react-workshop#8

Merged

dependabot bot mentioned this pull request Mar 13, 2021

Bump babel-jest from 18.0.0 to 23.6.0 CartoonIsArt/eevee#133

Closed

github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve the message when run coverage while there are no tests #6334

Improve the message when run coverage while there are no tests #6334

rhysawilliams2010 commented May 29, 2018 •

edited by thymikee

Loading

SimenB May 29, 2018

SimenB commented May 29, 2018

codecov-io commented May 29, 2018 •

edited

Loading

SimenB May 29, 2018

aaronabramov May 29, 2018

aaronabramov left a comment

aaronabramov May 29, 2018

SimenB commented May 29, 2018

rhysawilliams2010 commented May 29, 2018 •

edited

Loading

SimenB commented May 30, 2018

thymikee commented Jul 7, 2018

aaronabramov left a comment

github-actions bot commented May 12, 2021

Improve the message when run coverage while there are no tests #6334

Improve the message when run coverage while there are no tests #6334

Conversation

rhysawilliams2010 commented May 29, 2018 • edited by thymikee Loading

Summary

Test plan

SimenB May 29, 2018

Choose a reason for hiding this comment

SimenB commented May 29, 2018

codecov-io commented May 29, 2018 • edited Loading

Codecov Report

SimenB May 29, 2018

Choose a reason for hiding this comment

aaronabramov May 29, 2018

Choose a reason for hiding this comment

aaronabramov left a comment

Choose a reason for hiding this comment

aaronabramov May 29, 2018

Choose a reason for hiding this comment

SimenB commented May 29, 2018

rhysawilliams2010 commented May 29, 2018 • edited Loading

SimenB commented May 30, 2018

thymikee commented Jul 7, 2018

aaronabramov left a comment

Choose a reason for hiding this comment

github-actions bot commented May 12, 2021

rhysawilliams2010 commented May 29, 2018 •

edited by thymikee

Loading

codecov-io commented May 29, 2018 •

edited

Loading

rhysawilliams2010 commented May 29, 2018 •

edited

Loading