Add a "errorOnDeprecated" mode that errors when calling deprecated APIs #6339

captbaritone · 2018-05-29T16:03:18Z

These helpful errors, in concert with no-jasmine-globals and possible code mods (@aaronabramov) will help the community to upgrade to jest-circus in the next major release.

This also lays the groundwork for adding other helpful errors for deprecated features/APIs.

@SimenB I stole these from your eslint rule. Thanks!

… jasmine features. This lays the groundwork for adding other helpful errors for deprecated features/APIs.

captbaritone · 2018-05-29T16:05:24Z

e2e/__tests__/__snapshots__/error-on-deprecated.test.js.snap

+      12 | });
+      13 | 
+
+      at packages/jest-jasmine2/build/error_on_private.js:69:11


I thought I had trimmed this. I'll see if it's possible.

SimenB · 2018-05-29T16:12:33Z

Nice!

I wonder if we should also find other tings we want to deprecate, and add them as well?

EDIT: Reading, how even?

This also lays the groundwork for adding other helpful errors for deprecated features/APIs.

captbaritone · 2018-05-29T16:27:03Z

packages/jest-jasmine2/src/error_on_private.js

+      throwAtFunction(
+        'Illegal usage of `jasmine.DEFAULT_TIMEOUT_INTERVAL`, prefer `jest.setTimeout`.',
+        jasmine.set,
+      );


Whoops. Jest actually sets this under the hood, so I'll have to find a different way to do this.

is that related to why jest.setTimeout doesn't work in circus? #6277

thymikee · 2018-05-29T16:27:35Z

e2e/__tests__/error-on-deprecated.test.js

+  'spyOnProperty.test.js',
+]);
+
+testFiles.forEach(testFile => {


test.each maybe?

Ended up being a bit awkward:

#6348
#6349

thymikee · 2018-05-29T16:33:52Z

packages/jest-jasmine2/src/index.js

@@ -100,6 +101,10 @@ async function jasmine2(
      expand: globalConfig.expand,
    });

+  if (globalConfig.errorOnDeprecated) {
+    installErrorOnPrivate(environment.global);
+  }


I wonder if we should move this outside of jest jasmine. If user changes runner to circus, then depreciation errors will be gone, and only cryptic errors like "cannot call function on undefined" will surface

@thymikee Yeah, I'm planning on a followup to add this behavior to jest-circus as well.

Any idea where this could live that it would be shared by both?

captbaritone · 2018-05-29T22:00:53Z

EDIT: Reading, how even?

This also lays the groundwork for adding other helpful errors for deprecated features/APIs.

@SimenB I'm not sure I understand the question. Are you asking "How does this lay the groundwork?".

SimenB · 2018-05-29T22:14:20Z

Nah, It was mostly a response to my inability to read the OP properly - that it laid the groundwork for other deprecations

codecov-io · 2018-05-29T23:32:19Z

Codecov Report

Merging #6339 into master will increase coverage by 0.16%.
The diff coverage is 31.25%.

@@            Coverage Diff             @@
##           master    #6339      +/-   ##
==========================================
+ Coverage   63.63%   63.79%   +0.16%     
==========================================
  Files         226      229       +3     
  Lines        8648     8717      +69     
  Branches        4        4              
==========================================
+ Hits         5503     5561      +58     
- Misses       3144     3155      +11     
  Partials        1        1

Impacted Files	Coverage Δ
packages/jest-config/src/defaults.js	`92.85% <ø> (ø)`	⬆️
packages/jest-config/src/valid_config.js	`100% <ø> (ø)`	⬆️
packages/jest-jasmine2/src/index.js	`16.5% <0%> (+0.5%)`	⬆️
packages/jest-config/src/index.js	`31.37% <0%> (ø)`	⬆️
packages/jest-config/src/normalize.js	`93.85% <100%> (ø)`	⬆️
packages/jest-jasmine2/src/error_on_private.js	`26.66% <36.36%> (ø)`
packages/jest-each/src/index.js	`70.58% <0%> (-7.19%)`	⬇️
packages/jest-circus/src/index.js	`61.53% <0%> (-5.13%)`	⬇️
packages/jest-each/src/bind.js	`97.87% <0%> (-2.13%)`	⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2307643...e0483f2. Read the comment docs.

rickhanlonii

LGTM

captbaritone · 2018-05-30T04:18:37Z

Okay, I've removed the DEFAULT_TIMEOUT_INTERVAL check, since it's going to be a bit more invasive to get it to work. I'll open a second PR once this gets merged and we can discuss there.

github-actions · 2021-05-12T13:15:24Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

Add a "errorOnDeprecated" mode that errors when accessing unsupported…

141f92b

… jasmine features. This lays the groundwork for adding other helpful errors for deprecated features/APIs.

captbaritone commented May 29, 2018

View reviewed changes

facebook-github-bot added the cla signed label May 29, 2018

captbaritone commented May 29, 2018

View reviewed changes

thymikee reviewed May 29, 2018

View reviewed changes

captbaritone mentioned this pull request May 29, 2018

Ship Jest Circus #6295

Closed

6 tasks

Ignore error-on-deprecated in circus... for now

b852e5d

rickhanlonii approved these changes May 30, 2018

View reviewed changes

Trim stacktrace

e5c86c4

captbaritone force-pushed the strict-mode branch from 0a3d3b9 to e5c86c4 Compare May 30, 2018 03:13

captbaritone added 2 commits May 29, 2018 21:00

Fix typos

4416b62

Remove deprecation error for DEFAULT_TIMEOUT_INTERVAL

e0483f2

SimenB approved these changes May 30, 2018

View reviewed changes

cpojer merged commit 9b3b583 into jestjs:master May 30, 2018

SimenB mentioned this pull request May 30, 2018

Fix ci #6356

Merged

captbaritone mentioned this pull request May 31, 2018

Allow --errorOnDeprecated to error on DEFAULT_TIMEOUT_INTERVAL #6367

Merged

dependencies bot mentioned this pull request Nov 1, 2018

Update jest in / from 22.1.4 to 23.6.0 leonardofaria/leozera-ui#250

Closed

snyk-bot mentioned this pull request Mar 17, 2020

[Snyk] Upgrade expect from 23.0.0 to 23.6.0 yowainwright/react-workshop#8

Merged

github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a "errorOnDeprecated" mode that errors when calling deprecated APIs #6339

Add a "errorOnDeprecated" mode that errors when calling deprecated APIs #6339

captbaritone commented May 29, 2018 •

edited

Loading

captbaritone May 29, 2018

SimenB commented May 29, 2018 •

edited

Loading

captbaritone May 29, 2018

SimenB May 29, 2018

thymikee May 29, 2018

captbaritone May 29, 2018

thymikee May 29, 2018

captbaritone May 29, 2018

captbaritone May 29, 2018

captbaritone commented May 29, 2018

SimenB commented May 29, 2018

codecov-io commented May 29, 2018 •

edited

Loading

rickhanlonii left a comment

captbaritone commented May 30, 2018

github-actions bot commented May 12, 2021

Add a "errorOnDeprecated" mode that errors when calling deprecated APIs #6339

Add a "errorOnDeprecated" mode that errors when calling deprecated APIs #6339

Conversation

captbaritone commented May 29, 2018 • edited Loading

Choose a reason for hiding this comment

SimenB commented May 29, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

captbaritone commented May 29, 2018

SimenB commented May 29, 2018

codecov-io commented May 29, 2018 • edited Loading

Codecov Report

rickhanlonii left a comment

Choose a reason for hiding this comment

captbaritone commented May 30, 2018

github-actions bot commented May 12, 2021

captbaritone commented May 29, 2018 •

edited

Loading

SimenB commented May 29, 2018 •

edited

Loading

codecov-io commented May 29, 2018 •

edited

Loading