Only test/deploy website if relevant files are changed #6626

endiliey · 2018-07-05T06:37:41Z

Summary

Even better if it could be scoped to detected changes in docs/ dir <3

Test plan

Test logic.
Consider this script

WEBSITE_CHANGED=$(git diff-tree --no-commit-id --name-only -r HEAD | grep -E -c "(^docs\/.*)|(^website\/.*)")
if [[ $WEBSITE_CHANGED == 0 ]]; then
    echo "No relevant website files has changed"
    exit 0;
else
    echo "Relevant website files has changed"
fi

Change in docs/website folder commit

No change in docs/website folder commit

Look at circleci

thymikee

Looks good enough to me!

endiliey · 2018-07-05T06:42:56Z

@thymikee still need refactor & work in progress (Still failing as well).
I think I'll create a website.sh.

review later

endiliey · 2018-07-05T07:38:13Z

This is ready for review.

SimenB · 2018-07-05T14:28:43Z

.circleci/website.sh

+        echo "Skipping deploy. Test website build"
+        cd website && yarn && yarn build
+    fi
+fi


Trailing newline?

SimenB · 2018-07-05T14:28:59Z

.circleci/website.sh

@@ -0,0 +1,30 @@
+#!/bin/bash


Should we have set -e or something?

true. I forget 😢

rickhanlonii · 2018-07-05T14:44:00Z

.circleci/website.sh

+
+FILES_CHANGED=$(git diff-tree --no-commit-id --name-only -r HEAD)
+if grep -E "(^docs\/.*)|(^website\/.*)" $FILES_CHANGED; then
+    echo "Skipping deploy & test. No relevant website files has changed"


Sorry for the nit but this should be:

No relevant website files have changed

endiliey · 2018-07-05T14:55:40Z

Alright this should be ok now. Had a small bug due to set -e causing auto exit on grep before

thymikee · 2018-07-05T15:22:20Z

.circleci/website.sh

+        sudo apt-get install default-jre rsync
+        wget https://artifacts.crowdin.com/repo/deb/crowdin.deb -O crowdin.deb
+        sudo dpkg -i crowdin.deb
+        sleep 5


is this sleep still needed?

Tbh i don't think it is needed but I'm just following the previous script. Want to remove ?

Docusaurus use it though
https://github.com/facebook/Docusaurus/blob/3566483aa5fbe0b9cd6988aa14b255f4092ca4c7/.circleci/config.yml#L83

i didn't use it on my test site. Still works flawlessly 😂
https://github.com/endiliey/endiliey.github.io/blob/4c6abe0786e2be11cda2ae7c8d847e957d6ba89d/.travis.yml#L37-L41

codecov-io · 2018-07-05T15:59:11Z

Codecov Report

Merging #6626 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6626   +/-   ##
=======================================
  Coverage   63.73%   63.73%           
=======================================
  Files         235      235           
  Lines        8935     8935           
  Branches        4        3    -1     
=======================================
  Hits         5695     5695           
  Misses       3239     3239           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6512ad...031b646. Read the comment docs.

This Pull Request renovates the package group "jest monorepo". - [jest-environment-node](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0` - [jest](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0` # Release Notes <details> <summary>facebook/jest</summary> ### [`v23.3.0`](https://github.com/facebook/jest/blob/master/CHANGELOG.md#2330) [Compare Source](jestjs/jest@v23.2.0...v23.3.0) ##### Features - `[jest-cli]` Allow watch plugin to be configured ([#6603](`https://github.com/facebook/jest/pull/6603`)) - `[jest-snapshot]` Introduce `toMatchInlineSnapshot` and `toThrowErrorMatchingInlineSnapshot` matchers ([#6380](`https://github.com/facebook/jest/pull/6380`)) ##### Fixes - `[jest-regex-util]` Improve handling already escaped path separators on Windows ([#6523](`https://github.com/facebook/jest/pull/6523`)) - `[jest-cli]` Fix `testNamePattern` value with interactive snapshots ([#6579](`https://github.com/facebook/jest/pull/6579`)) - `[jest-cli]` Fix enter to interrupt watch mode ([#6601](`https://github.com/facebook/jest/pull/6601`)) ##### Chore & Maintenance - `[website]` Switch domain to https://jestjs.io ([#6549](`https://github.com/facebook/jest/pull/6549`)) - `[tests]` Improve stability of `yarn test` on Windows ([#6534](`https://github.com/facebook/jest/pull/6534`)) - `[*]` Transpile object shorthand into Node 4 compatible syntax ([#6582](`https://github.com/facebook/jest/pull/6582`)) - `[*]` Update all legacy links to jestjs.io ([#6622](`https://github.com/facebook/jest/pull/6622`)) - `[docs]` Add docs for 23.1, 23.2, and 23.3 ([#6623](`https://github.com/facebook/jest/pull/6623`)) - `[website]` Only test/deploy website if relevant files are changed ([#6626](`https://github.com/facebook/jest/pull/6626`)) - `[docs]` Describe behavior of `resetModules` option when set to `false` ([#6641](`https://github.com/facebook/jest/pull/6641`)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).

github-actions · 2021-05-12T12:06:57Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

Only test/build website if docs/website are changed

a5ec8eb

facebook-github-bot added the cla signed label Jul 5, 2018

thymikee previously approved these changes Jul 5, 2018

View reviewed changes

endiliey added 3 commits July 5, 2018 14:46

Refactor into website.sh

56dfdd2

nits

234b52b

chmod executable :)

f14584b

endiliey changed the title ~~[WIP] Only test/deploy website if relevant files are changed~~ Only test/deploy website if relevant files are changed Jul 5, 2018

add more echo strings

a4de210

SimenB reviewed Jul 5, 2018

View reviewed changes

endiliey added 2 commits July 5, 2018 22:30

review

36d421b

refactor

6eb2de1

rickhanlonii reviewed Jul 5, 2018

View reviewed changes

fix & nits

f677baf

SimenB approved these changes Jul 5, 2018

View reviewed changes

thymikee reviewed Jul 5, 2018

View reviewed changes

rm -rf sleep 5

031b646

thymikee approved these changes Jul 5, 2018

View reviewed changes

thymikee added 2 commits July 5, 2018 22:28

update changelog

4cb2bc3

Merge branch 'master' into web

59f955b

thymikee merged commit 14e8bbf into jestjs:master Jul 5, 2018

endiliey deleted the web branch July 6, 2018 03:55

This was referenced Jul 7, 2018

Update jest-environment-jsdom in / from 23.1.0 to 23.3.0 opencomponents/base-templates#320

Closed

Update jest in / from 23.1.0 to 23.3.0 opencomponents/base-templates#321

Merged

Update jest in / from 23.1.0 to 23.3.0 severest/retrobot#161

Closed

This was referenced Aug 1, 2018

Update jest in /modules/api from 22.4.3 to 23.4.2 project-accelerate/accelerate#207

Open

Update jest in /modules/frontend from 22.4.3 to 23.4.2 project-accelerate/accelerate#235

Open

dependencies bot mentioned this pull request Nov 1, 2018

Update jest in / from 22.1.4 to 23.6.0 leonardofaria/leozera-ui#250

Closed

snyk-bot mentioned this pull request Mar 17, 2020

[Snyk] Upgrade expect from 23.0.0 to 23.6.0 yowainwright/react-workshop#8

Merged

github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only test/deploy website if relevant files are changed #6626

Only test/deploy website if relevant files are changed #6626

endiliey commented Jul 5, 2018 •

edited

Loading

thymikee left a comment

endiliey commented Jul 5, 2018

endiliey commented Jul 5, 2018 •

edited

Loading

SimenB Jul 5, 2018

SimenB Jul 5, 2018

endiliey Jul 5, 2018

rickhanlonii Jul 5, 2018 •

edited

Loading

endiliey commented Jul 5, 2018

thymikee Jul 5, 2018

endiliey Jul 5, 2018 •

edited

Loading

thymikee Jul 5, 2018

codecov-io commented Jul 5, 2018 •

edited

Loading

github-actions bot commented May 12, 2021

Only test/deploy website if relevant files are changed #6626

Only test/deploy website if relevant files are changed #6626

Conversation

endiliey commented Jul 5, 2018 • edited Loading

Summary

Test plan

thymikee left a comment

Choose a reason for hiding this comment

endiliey commented Jul 5, 2018

endiliey commented Jul 5, 2018 • edited Loading

SimenB Jul 5, 2018

Choose a reason for hiding this comment

SimenB Jul 5, 2018

Choose a reason for hiding this comment

endiliey Jul 5, 2018

Choose a reason for hiding this comment

rickhanlonii Jul 5, 2018 • edited Loading

Choose a reason for hiding this comment

endiliey commented Jul 5, 2018

thymikee Jul 5, 2018

Choose a reason for hiding this comment

endiliey Jul 5, 2018 • edited Loading

Choose a reason for hiding this comment

thymikee Jul 5, 2018

Choose a reason for hiding this comment

codecov-io commented Jul 5, 2018 • edited Loading

Codecov Report

github-actions bot commented May 12, 2021

endiliey commented Jul 5, 2018 •

edited

Loading

endiliey commented Jul 5, 2018 •

edited

Loading

rickhanlonii Jul 5, 2018 •

edited

Loading

endiliey Jul 5, 2018 •

edited

Loading

codecov-io commented Jul 5, 2018 •

edited

Loading