Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove jest-editor-support and jest-test-typescript-parser from the repo #7232

Merged
merged 2 commits into from
Oct 21, 2018

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Oct 21, 2018

Summary

This has been extracted out: https://github.com/jest-community/jest-editor-support

@orta we should probably create something for jest-test-typescript-parser as well?

Test plan

Green CI (I haven't ran the tests locally, but I don't think we had any e2e tests for this?)

@codecov-io
Copy link

Codecov Report

Merging #7232 into master will decrease coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7232      +/-   ##
==========================================
- Coverage   67.27%   66.49%   -0.78%     
==========================================
  Files         248      237      -11     
  Lines        9652     9302     -350     
  Branches        3        3              
==========================================
- Hits         6493     6185     -308     
+ Misses       3158     3116      -42     
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18dcf3c...3504346. Read the comment docs.

@orta
Copy link
Member

orta commented Oct 21, 2018

Thanks man, yeah, I've been wondering if it even needs to exist, we originally didn't include it so that the jest set of repos didn't include typescript and now that problem doesn't exist - so should be fine

@orta
Copy link
Member

orta commented Oct 21, 2018

OK, let's get this done - note: e9818dc is the last commit with it included (for the final bits of porting)

@orta orta merged commit db42dfb into jestjs:master Oct 21, 2018
@SimenB SimenB deleted the remove-editor-support branch October 21, 2018 16:40
@connectdotz
Copy link
Contributor

@orta, vscode-jest uses jest-test-typescript-parser to parse typescript test files (here) because babylon (babel-6) doesn't parse typescript.

If you plan to move to babel-7, then you can consider using its new typescript plugin, however you will probably need to do some test to ensure this new babel's plugin is as capable as the typescript parser used in jest-test-typescript-parser, regarding test blocks/snapshot parsing etc.

if you are not ready to move to babel-7/babel-typescript-plugin and do all the testing, then we should probably port jest-test-typescript-parser over for now... maybe not necessary to a new package but as part of the jest-community/jest-editor-support...

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants