Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle objects with no constructor in hasOwnProperty #7334

Merged
merged 2 commits into from
Nov 7, 2018

Conversation

ryanoglesby08
Copy link
Contributor

I'm not super excited about the fix, so any feedback is welcome! It got hairy really quick, and looking at the docs for Object.create, I can see how this is a weird edge case that some have run into (including myself)

Summary

This problem is discussed in #6730 .

In short, objects created using unconventional means such as Object.create(null) will not have a constructor property, causing an exception to be throw in "packages/expect/src/utils.js" hasOwnProperty function.

This odd behavior of JS objects is discussed in depth in the MDN docs here.

Test plan

Added a test case to the unit tests for toMatchObject matcher. The included test case will throw an error TypeError: Cannot read property 'prototype' of undefined without the included fix.

Closes #6730

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SimenB SimenB merged commit 4859600 into jestjs:master Nov 7, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expect.toMatchObject throws TypeError instead of showing diff
4 participants