Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for copyright headers #7370

Merged

Conversation

rubennorte
Copy link
Contributor

@rubennorte rubennorte commented Nov 15, 2018

Summary

Added a script to verify that source files contain the Facebook copyright header. Facebook has an internal tool to verify it and will help aligning them.

Test plan

echo '// Non-empty' > packages/jest/foo.js
git add packages/jest/foo.js
yarn run check-copyright-headers

The output should be something like:

Facebook copyright header check failed for the following files:

  packages/jest/foo.js

Please include the header or blacklist the files in `scripts/checkCopyrightHeaders.js`
error Command failed with exit code 1.

And the exit code must be 1 if it failed and 0 otherwise.

The lint-and-typecheck job should check this. Example: https://circleci.com/gh/facebook/jest/39078

@rubennorte rubennorte force-pushed the add-check-for-copyright-headers branch from 3c20bea to f2472dd Compare November 15, 2018 14:25
@rubennorte rubennorte requested review from rickhanlonii, SimenB and mjesun and removed request for SimenB November 15, 2018 14:25
@rubennorte rubennorte merged commit b7ee7bd into jestjs:master Nov 15, 2018
@rubennorte rubennorte deleted the add-check-for-copyright-headers branch November 15, 2018 14:53
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants