Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize File Name #7467

Merged
merged 9 commits into from
Dec 5, 2018
Merged

Standardize File Name #7467

merged 9 commits into from
Dec 5, 2018

Conversation

GGonryun
Copy link
Contributor

@GGonryun GGonryun commented Dec 5, 2018

Summary

This Pull Request helps standardizes file names in ./e2e/babel-plug-in-jest-host under Facebook naming conventions as outlined in issue #4969 & below:

  • All folders -> kabab-case
  • All files that export a single Class -> CapitalizeCase
  • All files that export a single function -> camelCase
  • All other files -> underscore_case
  • Folders surrounded by __ (eg. tests) -> Stay the same.

Test plan

No new tests were added. I used ..\..\packages\jest-cli\bin\jest.js while in the folder .\e2e\babel-plug-in-jest-hoist to verify that all tests passed.

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are some things that still need to be addressed though

}
],
"retainLines": true
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the issue I was having here: #7466. i was able to resolve it by removing the file. But I accidentally added this to the last commit it wasn't supposed to be pushed. I meant to ask about adding this separately since it seemed to have resolved the issue for me.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the issue I was having here: #7466. i was able to resolve it by removing the file

I don't experience this under macOS. Probably something Windows related. But generally it should work, maybe you didn't run yarn inside this directory?

Anyway, please add extra newline back :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused as to where to put the newline, I copied the contents back from the original file over to this file from github. 😕

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scratch that! I found it. :)

@@ -123,7 +123,7 @@ describe('babel-plugin-jest-hoist', () => {
});

it('requires modules that also call jest.mock', () => {
require('../mock-file');
require('../mock_file');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why underscore? this should be mockFile

@codecov-io
Copy link

codecov-io commented Dec 5, 2018

Codecov Report

Merging #7467 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #7467   +/-   ##
======================================
  Coverage    66.8%   66.8%           
======================================
  Files         242     242           
  Lines        9375    9375           
  Branches        5       6    +1     
======================================
  Hits         6263    6263           
  Misses       3110    3110           
  Partials        2       2
Impacted Files Coverage Δ
e2e/babel-plugin-jest-hoist/mockFile.js 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 053b741...bae77b4. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@thymikee thymikee merged commit 24d82f0 into jestjs:master Dec 5, 2018
@GGonryun GGonryun deleted the standardize-file-naming branch December 5, 2018 18:47
thymikee added a commit to spion/jest that referenced this pull request Dec 18, 2018
* master: (24 commits)
  Add `jest.isolateModules` for scoped module initialization (jestjs#6701)
  Migrate to Babel 7 (jestjs#7016)
  docs: changed "Great Scott!" link (jestjs#7524)
  Use reduce instead of filter+map in dependency_resolver (jestjs#7522)
  Update Configuration.md (jestjs#7455)
  Support dashed args (jestjs#7497)
  Allow % based configuration of max workers (jestjs#7494)
  chore: Standardize filenames: jest-runner pkg (jestjs#7464)
  allow `bail` setting to control when to bail out of a failing test run (jestjs#7335)
  Add issue template labels (jestjs#7470)
  chore: standardize filenames in e2e/babel-plugin-jest-hoist (jestjs#7467)
  Add node worker-thread support to jest-worker (jestjs#7408)
  Add `testPathIgnorePatterns` to CLI documentation (jestjs#7440)
  pretty-format: Omit non-enumerable symbol properties (jestjs#7448)
  Add Jest Architecture overview to docs. (jestjs#7449)
  chore: run appveyor tests on node 10
  chore: fix failures e2e test for node 8 (jestjs#7446)
  chore: update docusaurus to v1.6.0 (jestjs#7445)
  Enhancement/expect-to-be-close-to-with-infinity (jestjs#7444)
  Update CHANGELOG formatting (jestjs#7429)
  ...
willsmythe pushed a commit to willsmythe/jest that referenced this pull request Dec 20, 2018
captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants