Allow % based configuration of max workers #7494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7494 +/- ##
==========================================
+ Coverage 67.44% 67.46% +0.01%
==========================================
Files 247 247
Lines 9511 9516 +5
Branches 6 6
==========================================
+ Hits 6415 6420 +5
Misses 3094 3094
Partials 2 2
Continue to review full report at Codecov.
|
|
Thoughts @cpojer? |
|
Sure. |
rickhanlonii
approved these changes
Dec 11, 2018
Co-Authored-By: phawxby <[email protected]>
|
LGTM, thanks! |
thymikee
added a commit
to spion/jest
that referenced
this pull request
Dec 18, 2018
* master: (24 commits) Add `jest.isolateModules` for scoped module initialization (jestjs#6701) Migrate to Babel 7 (jestjs#7016) docs: changed "Great Scott!" link (jestjs#7524) Use reduce instead of filter+map in dependency_resolver (jestjs#7522) Update Configuration.md (jestjs#7455) Support dashed args (jestjs#7497) Allow % based configuration of max workers (jestjs#7494) chore: Standardize filenames: jest-runner pkg (jestjs#7464) allow `bail` setting to control when to bail out of a failing test run (jestjs#7335) Add issue template labels (jestjs#7470) chore: standardize filenames in e2e/babel-plugin-jest-hoist (jestjs#7467) Add node worker-thread support to jest-worker (jestjs#7408) Add `testPathIgnorePatterns` to CLI documentation (jestjs#7440) pretty-format: Omit non-enumerable symbol properties (jestjs#7448) Add Jest Architecture overview to docs. (jestjs#7449) chore: run appveyor tests on node 10 chore: fix failures e2e test for node 8 (jestjs#7446) chore: update docusaurus to v1.6.0 (jestjs#7445) Enhancement/expect-to-be-close-to-with-infinity (jestjs#7444) Update CHANGELOG formatting (jestjs#7429) ...
willsmythe
pushed a commit
to willsmythe/jest
that referenced
this pull request
Dec 20, 2018
* Allow % based configuration of max workers * Add pull ref * Whoops, copy and paste * Update docs/CLI.md Co-Authored-By: phawxby <[email protected]> * Move changlog entry
captain-yossarian
pushed a commit
to captain-yossarian/jest
that referenced
this pull request
Jul 18, 2019
* Allow % based configuration of max workers * Add pull ref * Whoops, copy and paste * Update docs/CLI.md Co-Authored-By: phawxby <[email protected]> * Move changlog entry
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have various machines in use between 4-16 threads but we always need to have spare threads available for other things like puppeteer/chrome. Doing this will allow simple
--maxWorkers=50%to always have spare CPU available;Test plan