Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback write-file-atomic #7725

Merged
merged 3 commits into from
Jan 29, 2019
Merged

rollback write-file-atomic #7725

merged 3 commits into from
Jan 29, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 27, 2019

Summary

Closes #7709. We're also seeing this error in CI, e.g. https://dev.azure.com/jestjs/jest/_build/results?buildId=264

I think this is caused by npm/write-file-atomic@3365a4d

EDIT: If that's the case, 2.4.1 should be safe actually. Lemme try that.

Test plan

Green Windows build on azure.

@@ -28,8 +28,8 @@
"micromatch": "^3.1.10",
"realpath-native": "^1.0.0",
"slash": "^2.0.0",
"strip-bom": "3.0.0",
"write-file-atomic": "^2.4.2",
"strip-bom": "^3.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this, I just noticed it

@codecov-io
Copy link

Codecov Report

Merging #7725 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7725   +/-   ##
=======================================
  Coverage   68.27%   68.27%           
=======================================
  Files         252      252           
  Lines        9682     9682           
  Branches        5        5           
=======================================
  Hits         6610     6610           
  Misses       3070     3070           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c46752...6c0447a. Read the comment docs.

Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this does fix the build, not much to complain about 😅

@SimenB
Copy link
Member Author

SimenB commented Jan 27, 2019

It fixed the cache write error. Not sure why it hangs on attempting to detect open handles, though...

@lukeapage
Copy link
Contributor

I am seeing hangs on build machines with 2.4.1 too (though can confirm it fixes the errors)
The issue can affect jest v23 as well as the latest if you re-install, because the previous version used ^ dependency

@SimenB
Copy link
Member Author

SimenB commented Jan 28, 2019

Yeah, this is just a temp thing, hopefully it's fixed upstream (I got a response on the comment linked in the OP)

@SimenB
Copy link
Member Author

SimenB commented Jan 29, 2019

When upstream comes out with a fix, we can upgrade again, but I think I'm gonna land this in the meantime

@SimenB SimenB merged commit 31b81ba into jestjs:master Jan 29, 2019
@SimenB SimenB deleted the windows-ci branch January 29, 2019 14:36
@davidhouweling
Copy link

@SimenB any idea when this will be published?

@SimenB
Copy link
Member Author

SimenB commented Feb 5, 2019

No, sorry. The people making releases are super busy now, but I hope we can get a release out soon. (although I cannot tell you what "soon" means)

@jeysal
Copy link
Contributor

jeysal commented Feb 5, 2019

24.1.0 is released

captain-yossarian pushed a commit to captain-yossarian/jest that referenced this pull request Jul 18, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest fails with EBADF: bad file descriptor, close
6 participants