Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for existence of Element when comparing DOM-nody-things (#7786) (clean cherry pick version) #7995

Merged
merged 8 commits into from
Mar 1, 2019
Merged

Check for existence of Element when comparing DOM-nody-things (#7786) (clean cherry pick version) #7995

merged 8 commits into from
Mar 1, 2019

Conversation

mfeineis
Copy link
Contributor

Summary

This is a clean spin-off of the current master with the meaningful commits cherry-picked on top made as a result of PR #7791

@pedrottimark I hope this is easier to handle than the rebased mess I made earlier 😄

SLA signed and still first contribution

Copy link
Contributor

@pedrottimark pedrottimark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for finding the problem and following through with a solution.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the changelog? Code LGTM 🙂

@mfeineis
Copy link
Contributor Author

mfeineis commented Mar 1, 2019

Done, it's always a pleasure to delete code with a PR 😄

@pedrottimark
Copy link
Contributor

I pushed a change directly to your PR to replace 7786 with 7995 as text of link (the link was correct)

As soon as CI passes again, I will merge.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants