Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create @jest/test-results package #8034

Merged
merged 6 commits into from
Mar 5, 2019

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 3, 2019

Summary

I wanted to remove it from @jest/types. Thought about sticking it in @jest/reporters, but I think a separate package is fine

Test plan

Green CI

"@jest/console": "^24.1.0",
"@types/istanbul-lib-coverage": "^1.1.0"
"@types/istanbul-lib-coverage": "^1.1.0",
"@types/yargs": "^12.0.9"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was missing

import * as Global from './Global';

export {Config, TestResult, Global};
export {Config, Global};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost rid of the whole thing

@SimenB
Copy link
Member Author

SimenB commented Mar 4, 2019

I'll land this after #7970 to avoid churn in it

@SimenB
Copy link
Member Author

SimenB commented Mar 5, 2019

Just tweaked types in the last one, the other builds were happy. No need to wait

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants