-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check for common errors when using the wrong test environment #8245
Conversation
Not sure there's a better way, if we make this a separate util and use |
9537dd9
to
4144568
Compare
@scotthovestadt thoughts on this (beyond failing CI)? |
Any help needed with this (or something else related to #5815)? |
I had completely forgotten about this one, thanks for the bump! Lemme try to rebase this and move the logic to |
330c27d
to
b68f138
Compare
Codecov Report
@@ Coverage Diff @@
## master #8245 +/- ##
=======================================
Coverage 64.93% 64.93%
=======================================
Files 288 288
Lines 12190 12199 +9
Branches 3023 3024 +1
=======================================
+ Hits 7916 7922 +6
- Misses 3636 3638 +2
- Partials 638 639 +1
Continue to review full report at Codecov.
|
23182a9
to
d214b34
Compare
Thinking about it, I'll just leave it where it is, as the source of the error might be in many places it's nice to not have the logic spread around. And since the function is not exported, if we later want to move/refactor it it's not a breaking change |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
For #5815.
This probably should not live in
jest-message-util
, but that was the easiest to cover exec errors (fromjest-runtime
) and test errors (fromjest-jasmine
andjest-circus
). Thoughts on how to better organise it?Also, sucky message 😅 Ideas?
Test plan
e2e tests added