-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jest-get-type] Simplify checking for primitive #8416
[jest-get-type] Simplify checking for primitive #8416
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8416 +/- ##
==========================================
- Coverage 62.32% 62.32% -0.01%
==========================================
Files 266 266
Lines 10734 10733 -1
Branches 2615 2614 -1
==========================================
- Hits 6690 6689 -1
Misses 3461 3461
Partials 583 583
Continue to review full report at Codecov.
|
Benchmarks on perf? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's actually a quite beautiful way of doing it 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Elegant solution.
Change log please.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
I just simplified checking for primitive type and improve performance.
Test plan
There were already tests, but I added some more