Updated config docs - transform #8583

danm · 2019-06-19T13:04:59Z

I've added a default option to clear up any confusion, hopefully that will make it more obvious how it should be added back in when additional transformers are added.

Summary

It wasn't clear to me when adding an SVG transformer that the default transformer is ignored. Especially as in the docs the default is undefined

As per #8574 it was recommended I could update the docs to make this a little clearer

Test plan

docs only.

facebook-github-bot · 2019-06-19T13:05:13Z

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot · 2019-06-19T13:09:20Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

jeysal

Thanks @danm!
@SimenB any concerns with having the default mentioned in the docs deviate from the defaults.ts (if they are the effective defaults, just handled specially)? It's not auto generated or something so...

docs/Configuration.md

danm

Thanks! I have updated according to your suggestions. Thanks for being nice :)

codecov-io · 2019-06-19T17:52:35Z

Codecov Report

Merging #8583 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8583   +/-   ##
=======================================
  Coverage   63.24%   63.24%           
=======================================
  Files         272      272           
  Lines       11311    11311           
  Branches     2760     2761    +1     
=======================================
  Hits         7154     7154           
  Misses       3540     3540           
  Partials      617      617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9ccf9...397a95a. Read the comment docs.

SimenB

This is great, thanks! Could you also update the versioned docs?

jeysal · 2019-06-20T14:00:55Z

@SimenB for versioned docs, below v24 would have to be ^.+\\.jsx?$, but other than that the text applies to all versions, correct?

SimenB · 2019-07-16T14:05:26Z

@jeysal yup, the pattern changed just for 24, otherwise the docs should match 🙂

jeysal · 2019-08-11T17:19:15Z

@danm mind adding the mentioned changes to website/versioned_docs to this PR?
Feel free to ask if we were unclear about anything :)

SimenB · 2019-11-09T16:22:53Z

@danm ping

I've added a default option to clear up any confusion, hopefully that will make it more obvious how it should be added back in when additional transformers are added.

Co-Authored-By: Tim Seckinger <[email protected]>

thymikee

Rebased and updated versioned docs

thymikee · 2020-05-02T18:12:30Z

Thank you @danm! Looking forward to future contributions 😊

…hile-running * upstream/master: (331 commits) chore: update ts-eslint (jestjs#9953) Updated config docs with default transform value (jestjs#8583) Update jest-phabricator documentation (jestjs#8662) chore: remove dependency on `realpath-native` (jestjs#9952) chore: bump dated dependencies (jestjs#9951) chore: another try at fixing test-utils dependency chore: update lockfile due to beta release chore: move changelog entry and fix tets utils dependency Fix time duration formatting as per SI (jestjs#9765) v26.0.0-alpha.0 chore: run some jsdom tests in leak check (jestjs#9938) chore: upgrade chalk to v4 (jestjs#9752) feat: upgrade to JSDOM 16 (jestjs#9606) chore: remove checks for compileFunction (jestjs#9949) chore: drop node 8 support (jestjs#9423) Remove leftover `providesModuleNodeModules` (jestjs#9948) [BREAKING] Pojer -> Nakazawa chore: revert lockfile changes from 2b32fe6 chore: move changelog entry and fix lint Remove `providesModuleNodeModules` from Jest. (jestjs#9583) ...

github-actions · 2021-05-11T07:07:46Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

danm added a commit to danm/jest that referenced this pull request Jun 19, 2019

Updated change log for jestjs#8583

b297300

facebook-github-bot added the cla signed label Jun 19, 2019

jeysal reviewed Jun 19, 2019

View reviewed changes

docs/Configuration.md Outdated Show resolved Hide resolved

docs/Configuration.md Outdated Show resolved Hide resolved

danm commented Jun 19, 2019

View reviewed changes

SimenB approved these changes Jun 20, 2019

View reviewed changes

thymikee added the Documentation 📖 label Nov 19, 2019

danm and others added 7 commits May 2, 2020 19:57

Updated config docs - transform

b77f0d9

I've added a default option to clear up any confusion, hopefully that will make it more obvious how it should be added back in when additional transformers are added.

Updated change log for jestjs#8583

b993797

Update docs/Configuration.md

4914a5b

Co-Authored-By: Tim Seckinger <[email protected]>

Update Configuration.md

c52b3cc

transform is an object instead of array - fixing.

07c9de5

--amend

4449f7e

update versioned docs

f69a0b0

thymikee force-pushed the patch-1 branch from a418c24 to f69a0b0 Compare May 2, 2020 18:02

thymikee approved these changes May 2, 2020

View reviewed changes

thymikee merged commit 3078172 into jestjs:master May 2, 2020

snyk-bot mentioned this pull request Dec 17, 2020

[Snyk] Fix for 1 vulnerabilities tjenkinson/jest#56

Open

github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated config docs - transform #8583

Updated config docs - transform #8583

danm commented Jun 19, 2019

facebook-github-bot commented Jun 19, 2019

facebook-github-bot commented Jun 19, 2019

jeysal left a comment

danm left a comment

codecov-io commented Jun 19, 2019

SimenB left a comment

jeysal commented Jun 20, 2019

SimenB commented Jul 16, 2019

jeysal commented Aug 11, 2019

SimenB commented Nov 9, 2019

thymikee left a comment

thymikee commented May 2, 2020

github-actions bot commented May 11, 2021

Updated config docs - transform #8583

Updated config docs - transform #8583

Conversation

danm commented Jun 19, 2019

Summary

Test plan

facebook-github-bot commented Jun 19, 2019

facebook-github-bot commented Jun 19, 2019

jeysal left a comment

Choose a reason for hiding this comment

danm left a comment

Choose a reason for hiding this comment

codecov-io commented Jun 19, 2019

Codecov Report

SimenB left a comment

Choose a reason for hiding this comment

jeysal commented Jun 20, 2019

SimenB commented Jul 16, 2019

jeysal commented Aug 11, 2019

SimenB commented Nov 9, 2019

thymikee left a comment

Choose a reason for hiding this comment

thymikee commented May 2, 2020

github-actions bot commented May 11, 2021