Issue 8547: side effect import deps extracted

[astigefb]

Summary

Jest previously wouldn't find changes to side-effect only imports when watching files.

#8547

Test plan

1. Added a test to make it fail
2. Made the test pass
3. Tried to ensure other tests failing / passing status were the same running a full yarn jest, but there's a fair amount of noise is pre-existing failures. Also tried to use yarn jest --json --outputFile=[...] before and after but a lot of noise there in comparing. Settled for similar looking summaries before / after that looks something like the below when run close together:

Snapshot Summary
› 4 snapshots failed from 2 test suites. Inspect your code changes or run yarn run jest -u to update them.

Test Suites: 7 failed, 328 passed, 335 total
Tests: 12 failed, 9 skipped, 3465 passed, 3486 total
Snapshots: 4 failed, 1465 passed, 1469 total
Time: 154.846s, estimated 158s
Ran all test suites in 14 projects.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[jeysal]

Hi @astigefb, thanks for the PR!
There is already #8548, which seems to do this in a more comprehensive way I think. Maybe we should see if @dy93 can follow up on the review comment there so that the effort is not duplicated :)

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[astigefb]

@jeysal - Whoops I didn't notice someone else was working on this, thanks for the pointer / link~ I've copied in the negative tests from #8548, and looks like I happened to do the single regex request here. If there's anything else I'm missing let me know :)

@dy93 - I've added you as a co-author since I copied in some of your code. Though I wasn't sure what e-mail address to use, so I just put in a no-reply. If you want anything changed here, notice anything in this diff, etc let me know~

[dy93]

@astigefb Thanks! My email address is [email protected].

[astigefb]

@dy93 np :) I've added your e-mail to the commit~

[codecov-io]

Codecov Report

Merging #8670 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8670      +/-   ##
==========================================
- Coverage   63.46%   63.42%   -0.05%     
==========================================
  Files         274      274              
  Lines       11385    11385              
  Branches     2771     2771              
==========================================
- Hits         7226     7221       -5     
- Misses       3546     3547       +1     
- Partials      613      617       +4

Impacted Files	Coverage Δ
...ages/jest-haste-map/src/lib/dependencyExtractor.ts	95.45% <ø> (ø)	⬆️
packages/expect/src/spyMatchers.ts	89.02% <0%> (-2%)	⬇️
packages/jest-mock/src/index.ts	77.52% <0%> (-0.2%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b76f01b...9d9b320. Read the comment docs.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.