Fixed toHaveProperty returning false positives when looking for undefined property

[SixTfour]

Summary

Fix false positives when looking for undefined prop. {a:{}}.hasProperty('b', undefined) now returns false.

More info can be found here.

Fixes #8786

Test plan

Used commented test on line 1380 in packages/expect/src/__tests__/matchers.test.js.

// Input:
[{a: {}}, 'a.b', undefined], // wait until Jest 25
  ].forEach(([obj, keyPath, value]) => {
    test(`{pass: false} expect(${stringify(
      obj,
    )}).toHaveProperty('${keyPath}', ${stringify(value)})`, () => {
      expect(() =>
        jestExpect(obj).toHaveProperty(keyPath, value),
      ).toThrowErrorMatchingSnapshot();
      jestExpect(obj).not.toHaveProperty(keyPath, value);
    });
  });

// Output:
exports[`.toHaveProperty() {pass: false} expect({"a": {}}).toHaveProperty('a.b', undefined) 1`] = `
"<dim>expect(</><red>object</><dim>).toHaveProperty(</><green>path</><dim>, </><green>value</><dim>)</>

Expected the object:
  <red>{\\"a\\": {}}</>
To have a nested property:
  <green>\\"a.b\\"</>
With a value of:
  <green>undefined</>
Received:
  <red>object</>.a: <red>{}</>"
`;

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[codecov-io]

Codecov Report

Merging #8923 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #8923      +/-   ##
==========================================
- Coverage   64.29%   64.28%   -0.01%     
==========================================
  Files         276      276              
  Lines       11707    11702       -5     
  Branches     2864     2863       -1     
==========================================
- Hits         7527     7523       -4     
  Misses       3549     3549              
+ Partials      631      630       -1

Impacted Files	Coverage Δ
packages/expect/src/matchers.ts	97.16% <100%> (+0.29%)	⬆️
packages/expect/src/utils.ts	94.87% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 116303b...b18316a. Read the comment docs.

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[sklaus64]

Output now reflects new output format:

"<dim>expect(</><red>received</><dim>).</>toHaveProperty<dim>(</><green>path</><dim>, </><green>value</><dim>)</>

Expected path: <green>\\"a.b\\"</>
Received path: <red>\\"a\\"</>

Expected value: <green>undefined</>
Received value: <red>{}</>"

[SimenB]

Thank you! I'll leave this for @pedrottimark as he's the master of expect, but it LGTM 🙂

[pedrottimark]

Thank you. I need to take a more careful look at the new endPropIsDefined property, to make sure that we will be able to convert getPath function from recursive to iterative as a future chore.

[SixTfour]

Whoops. Forgot to take out that comment in matchers.test.js. Just fixed both of those issues. Thanks for taking a look at it @SimenB and @pedrottimark!

[pedrottimark]

@SimenB Is this an example of breaking change that we are postponing until Jest 26 milestone to maximize the number of people who can get the perf improvements in Jest 25?

[SimenB]

@pedrottimark yea, I think so

[SimenB]

@pedrottimark is this good to go you think?

[SimenB]

@SixTfour would you be up for rebasing this? 🙂

[cpojer]

@SixTfour sorry for the long wait here. Would you mind rebasing this PR one more time?

[SimenB]

thanks!

sorry about the delay 😅

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.