Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-environment-node: Add queueMicrotask #9140

Merged
merged 2 commits into from
Nov 6, 2019
Merged

jest-environment-node: Add queueMicrotask #9140

merged 2 commits into from
Nov 6, 2019

Conversation

BlackGlory
Copy link
Contributor

Fix #9139

@facebook-github-bot
Copy link
Contributor

Hi BlackGlory! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@BlackGlory BlackGlory marked this pull request as ready for review November 6, 2019 09:23
@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #9140 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9140      +/-   ##
==========================================
- Coverage   64.77%   64.77%   -0.01%     
==========================================
  Files         277      277              
  Lines       11722    11724       +2     
  Branches     2878     2879       +1     
==========================================
+ Hits         7593     7594       +1     
  Misses       3512     3512              
- Partials      617      618       +1
Impacted Files Coverage Δ
packages/jest-environment-node/src/index.ts 56.75% <50%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8da17b9...d5583ac. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thymikee thymikee requested a review from SimenB November 6, 2019 09:43
@SimenB SimenB merged commit 2f793b8 into jestjs:master Nov 6, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: queueMicrotask is not defined
5 participants