Fix util.promisify(setTimeout) on jest-fake-timers

[lourenci]

It closes #9150.

Some points to consider and help me to reach the best implementation.

• I've implemented setTimeout[util.promisify.custom] on jest-fake-timers like the original one implemented on node. It doesn't call the callback passed through it. Therefore this implementation differs from Lolex implementation.
• Since the implementation doesn't call the callback, I'm not sure about the best test strategy here. I can't assert for some mock function to be called.
• I don't know where is the right place to test this. My first attempt was to create a spec for each runTimers.... I still think this is the best strategy because it looks like it is more "black-boxed", but I did the implementation with the least effort to get some advice.

[facebook-github-bot]

Hi lourenci! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[codecov-io]

Codecov Report

Merging #9180 into master will decrease coverage by 0.23%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #9180      +/-   ##
==========================================
- Coverage   65.06%   64.83%   -0.24%     
==========================================
  Files         278      279       +1     
  Lines       11864    11743     -121     
  Branches     2924     2884      -40     
==========================================
- Hits         7719     7613     -106     
+ Misses       3518     3511       -7     
+ Partials      627      619       -8

Impacted Files	Coverage Δ
packages/jest-fake-timers/src/jestFakeTimers.ts	90.35% <100%> (+0.14%)	⬆️
packages/expect/src/jasmineUtils.ts	91.07% <0%> (-1.04%)	⬇️
packages/jest-reporters/src/coverage_reporter.ts	61.53% <0%> (-0.3%)	⬇️
packages/jest-haste-map/src/lib/FSEventsWatcher.ts	12.5% <0%> (-0.23%)	⬇️
packages/jest-runtime/src/index.ts	68.86% <0%> (-0.11%)	⬇️
packages/jest-haste-map/src/index.ts	81.21% <0%> (-0.06%)	⬇️
packages/jest-snapshot/src/utils.ts	95.29% <0%> (ø)	⬆️
...ckages/jest-reporters/src/generateEmptyCoverage.ts	88.88% <0%> (ø)	⬆️
packages/jest-config/src/index.ts	11.94% <0%> (ø)	⬆️
packages/jest-snapshot/src/index.ts	73.23% <0%> (ø)	⬆️
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429877d...b27f42b. Read the comment docs.

[jeysal]

Thanks for tackling this! I left comments where the code/test does not seem to be correct

[jeysal]

Can you add a changelog entry please? :)

[jeysal]

Made an edit that triggers Azure CI to run again, I think the macOS cancellation was just flakiness, let's see

[jeysal]

Alright, Azure passed. Node 13 failure happens everywhere now, unrelated. Thanks a lot for the contribution! :)

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.