Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pretty-format): correctly detect memo #9196

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Nov 17, 2019

Summary

Handles the change in facebook/react#17278

Test plan

Green CI

@codecov-io
Copy link

codecov-io commented Nov 17, 2019

Codecov Report

Merging #9196 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9196   +/-   ##
=======================================
  Coverage   64.83%   64.83%           
=======================================
  Files         279      279           
  Lines       11742    11742           
  Branches     2887     2886    -1     
=======================================
  Hits         7613     7613           
  Misses       3511     3511           
  Partials      618      618
Impacted Files Coverage Δ
packages/pretty-format/src/plugins/ReactElement.ts 86.48% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac3f2a5...410de01. Read the comment docs.

@SimenB SimenB merged commit 03b97d6 into jestjs:master Nov 17, 2019
@SimenB SimenB deleted the recat-is-memo branch November 17, 2019 17:14
ayush000 added a commit to ayush000/jest that referenced this pull request Nov 21, 2019
* master:
  chore: upgrade to fsevents 2 (jestjs#9215)
  docs: remove expect.assertions(1) in rejects example of Tutoria… (jestjs#9149)
  chore: bump to istanbul alphas (jestjs#9192)
  Fix typo in JestPlatform.md (jestjs#9212)
  jest-snapshot: Ignore indentation for most serialized objects (jestjs#9203)
  fix(jest-types): tighten Config types and set more defaults (jestjs#9200)
  jest-snapshot: Improve colors when snapshots are updatable (jestjs#9132)
  jest-snapshot: Omit irrelevant received properties when property matchers fail (jestjs#9198)
  chore: make changedFiles option optional in `shouldInstrument` (jestjs#9197)
  fix(pretty-format): correctly detect memo (jestjs#9196)
  chore: regenerate lockfiles in e2e tests (jestjs#9193)
  chore: bump handlebars
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants