Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash on unix based systems without find #9579

Merged
merged 5 commits into from
Feb 18, 2020
Merged

fix: crash on unix based systems without find #9579

merged 5 commits into from
Feb 18, 2020

Conversation

leonardovillela
Copy link
Contributor

Summary

Closes #9329

Test plan

Unit tests added

@codecov-io
Copy link

Codecov Report

Merging #9579 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9579      +/-   ##
==========================================
+ Coverage   65.07%   65.08%   +<.01%     
==========================================
  Files         286      286              
  Lines       12144    12146       +2     
  Branches     3010     3011       +1     
==========================================
+ Hits         7903     7905       +2     
  Misses       3605     3605              
  Partials      636      636
Impacted Files Coverage Δ
packages/jest-haste-map/src/crawlers/node.ts 85.88% <100%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63593a2...c3997c2. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think the helper needs some tweaks but overall this looks nice 👍

packages/jest-haste-map/src/crawlers/node.ts Outdated Show resolved Hide resolved
@drew-gross

This comment has been minimized.

@leonardovillela
Copy link
Contributor Author

Seems like the build is broken on Node v13.x on ubuntu-latest, but I couldn't understand why 🤔

@codecov-io
Copy link

Codecov Report

Merging #9579 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9579      +/-   ##
==========================================
+ Coverage   65.07%   65.11%   +0.03%     
==========================================
  Files         286      286              
  Lines       12144    12151       +7     
  Branches     3010     3011       +1     
==========================================
+ Hits         7903     7912       +9     
+ Misses       3605     3604       -1     
+ Partials      636      635       -1
Impacted Files Coverage Δ
packages/jest-haste-map/src/crawlers/node.ts 86.66% <100%> (+1.12%) ⬆️
packages/expect/src/utils.ts 96.22% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63593a2...ee303a1. Read the comment docs.

@SimenB SimenB merged commit 2b83f75 into jestjs:master Feb 18, 2020
@leonardovillela leonardovillela deleted the fix-crash-on-systems-without-find branch February 18, 2020 14:04
@gvanderest
Copy link

Sorry to bug you, but just curious how the Jest releases work and when this fix would become available to the public?

Thank you for the fix!

@DiZy
Copy link
Contributor

DiZy commented Feb 20, 2020

We can make a minor release by the end of the month!

@DanielViglione
Copy link

@DiZy would the minor release be in [email protected]? I am having this issue on Node12 on AWS, which is not even using Windows. It is using the Ubuntu Standard 3.0 Docker image.

@lovefamilychildrenhappiness

@DiZy status of this?

@TheEvilDev
Copy link

+1 also waiting on a release here. Is there anywhere documented your clear release schedule?

@lovefamilychildrenhappiness

I cannot even pull in the latest commits from the master branch:

$ npm i facebook/jest#master --save
npm ERR! Can't install github:facebook/jest#b5c7092687a265e3f4f2ba6f9787e47e8c6b9d5e: Missing package name

@SimenB
Copy link
Member

SimenB commented Mar 25, 2020

25.2.0 has been published with this fix


@lovefamilychildrenhappiness we don't support installing from github. I'll be looking into setting up canary publishes on every commit in the near future so people are not blocked by releases if they want the latest and greatest

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest crashes on systems without find
10 participants