-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add require stack & surface Yarn PnP #9681
Conversation
…ing require stack relative to rootdir instead of absolute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Sorry about the slow response, I've been swamped with dayjob stuff lately.
Also, please add a test for pnp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great!
It should be all good now. I've fixed another bug, when there is some kind of nesting of required modules ( I've fixed it by adding a There should not be any breaking changes AFAIK. In case a |
…he error bubles to the original requiring module
Codecov Report
@@ Coverage Diff @@
## master #9681 +/- ##
==========================================
- Coverage 65.09% 64.92% -0.17%
==========================================
Files 287 288 +1
Lines 12144 12184 +40
Branches 3007 3020 +13
==========================================
+ Hits 7905 7911 +6
- Misses 3604 3635 +31
- Partials 635 638 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you for being patient with me!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
<rootDir>
for convenience and linking when aMODULE_NOT_FOUND
error is thrown by the resolver.Solves #9594
Test plan
E2E tests included in
pnp
andresolve