Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jest-types): expose TransformedSource for transformers #9736

Merged
merged 2 commits into from
Apr 1, 2020
Merged

chore(jest-types): expose TransformedSource for transformers #9736

merged 2 commits into from
Apr 1, 2020

Conversation

ahnpnl
Copy link
Contributor

@ahnpnl ahnpnl commented Mar 31, 2020

Summary

Reference kulshekhar/ts-jest#1363 (comment)

Test plan

Not sure how to test this, probably Green CI ?

@SimenB
Copy link
Member

SimenB commented Mar 31, 2020

Thanks! Mind updating the changelog?

I also think we should update process to just return TransformedSource, and change TransformedSource to have a string union.

https://github.com/facebook/jest/blob/324938561c608e0e9dddc008e5dde1589d7abc68/packages/jest-transform/src/types.ts#L73

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit c1bea10 into jestjs:master Apr 1, 2020
@ahnpnl ahnpnl deleted the expose-extra-transform-type branch April 1, 2020 04:43
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants