Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usages of YogaConstants.UNDEFINED are replaced with instead of 1.0E21F after compilation. #536

Closed
1 task done
ex3ndr opened this issue Apr 15, 2019 · 3 comments
Closed
1 task done

Usages of YogaConstants.UNDEFINED are replaced with instead of 1.0E21F after compilation. #536

ex3ndr opened this issue Apr 15, 2019 · 3 comments

Comments

@ex3ndr
Copy link

ex3ndr commented Apr 15, 2019

Version

0.23

Issues and Steps to Reproduce

In compiled library all usages of YogaConstants.UNDEFINED are replaced with with 1.0E21F and this breaks runtime since YogaConstants.isUndefined(...) stops working at all. Because of this fblitho is incompatible with latest react-native.

image
@adityasharat
Copy link
Contributor

Thank you reporting this. We'll look into this.

@colriot
Copy link
Contributor

colriot commented May 3, 2019

@ex3ndr this will be fixed in the new version. We'll release it next week

@colriot
Copy link
Contributor

colriot commented May 13, 2019

Fixed in v0.26.0

@colriot colriot closed this as completed May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ex3ndr @colriot @adityasharat