[agp] Upgrade AGP, Kotlin, Gradle, maven publish plugin #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 20, 2024
passy
changed the title
passy
force-pushed
the
pr986
branch
3 times, most recently
from
8b19033
to
7d5f581
Compare
passy
force-pushed
the
pr986
branch
2 times, most recently
from
d546726
to
2ba7aea
Compare
passy
force-pushed
the
pr986
branch
2 times, most recently
from
f2b320b
to
f8acca7
Compare
passy
force-pushed
the
pr986
branch
2 times, most recently
from
922a09b
to
d038404
Compare
Closed
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
Summary:
The tests are not actually being run.
After upgrading the Gradle plugin on GitHub, it has become clear that these are running without the AP processing them. When processed, they raise some fairly obvious mistakes:
{P1221730610}
This is removing them for now so we can get the update and new release out.
Done using
```
pastry P1221730610 | rg -F '/src/' | awk '{print $1}' | cut -d ':' -f 1 | uniq | sed -e 's:/Users/realpassy/Projects/java/litho/::' | xargs hg rm -v
```
To restore the rests, let's do it one-by-one by doing `hg revert -r 5ac836c8ff21bb798ce1aba47a47857f93f3d47c^ -- litho-it/path/to/test.java`
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/litho/pull/988).
* #986
* #985
* __->__ #988
Pull Request resolved: #988
Reviewed By: adityasharat
Differential Revision: D58789067
Pulled By: passy
fbshipit-source-id: fb1aacd92dc88e0fb4d7ad4dc4c918396958fc3f
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
Summary: --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/litho/pull/985). * #986 * __->__ #985 Pull Request resolved: #985 Reviewed By: adityasharat Differential Revision: D58789157 Pulled By: passy fbshipit-source-id: 927868f3786576eb244d8a89c8c76623b9c3c03c
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@passy has updated the pull request. You must reimport the pull request before landing. |
1 similar comment
|
@passy has updated the pull request. You must reimport the pull request before landing. |
|
@passy has updated the pull request. You must reimport the pull request before landing. |
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@passy has updated the pull request. You must reimport the pull request before landing. |
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.