Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Ubuntu 12.04 #15

Closed
wants to merge 5 commits into from
Closed
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 47 additions & 2 deletions proxygen/deps.sh
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,51 @@ sudo apt-get install \
gperf \
autoconf-archive \
libevent-dev \
libgoogle-glog-dev \
wget

# Adding support for Ubuntu 12.04.x
# Needs libdouble-conversion-dev, google-gflags and double-conversion
# deps.sh in fbthrift and folly builds anyways (no trap there)
if ! sudo apt-get install libgoogle-glog-dev;
then
echo "fetching glog from svn (apt-get fails)"
if [ ! -e google-glog ]; then
svn checkout http://google-glog.googlecode.com/svn/trunk/ google-glog
cd google-glog
./configure
make
sudo make install
cd ..
fi
fi

if ! sudo apt-get install libgflags-dev;
then
if [ ! -e google-gflags ]; then
echo "Fetching and building libgflags"
wget https://github.com/schuhschuh/gflags/archive/v2.0.tar.gz
mkdir google-gflags
tar xf v2.0.tar.gz -C google-gflags
cd google-gflags/gflags-2.0/
./configure
make
sudo make install
cd ../../
fi
fi

if ! sudo apt-get install libdouble-conversion-dev;
then
if [ ! -e double-conversion ]; then
git clone https://code.google.com/p/double-conversion double-conversion
cd double-conversion
cmake . -DBUILD_SHARED_LIBS=ON
sudo make install
cd ..
fi
fi


git clone https://github.com/facebook/fbthrift || true
cd fbthrift/thrift

Expand All @@ -41,7 +83,10 @@ if [ -e folly/folly ]; then
fi

# Build folly and fbthrift
./deps.sh
if ! ./deps.sh; then
echo "fatal: Build failing"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this "fatal: fbthrift+folly build failed"

exit -1
fi

# Build proxygen
cd ../..
Expand Down