Fixed minor typo #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, can you sign the CLA first? https://code.facebook.com/cla |
|
@dcsommer already signed it half-dozen times already, thanks |
|
That's strange. Our system shows that you haven't signed it. Would you mind signing one more time? |
|
Thanks again Pascal! Just forwarded your CLA in the right direction. |
|
@stoyan thx 👍 |
|
heh, I was 6 hours too slow reading the README. |
adammcarth
added a commit
to adammcarth/proxygen
that referenced
this pull request
Nov 6, 2014
- Moved directory explanation list into a table. Easier on the eyes. - Added contribution guidelines, including information regarding the CLA. - Merged in [Pascal Borreli's typo fix](facebook#6) for "HTTPTransaction".
dcsommer
added a commit
that referenced
this pull request
Nov 7, 2014
Summary: - Moved directory explanation list into a table. Easier on the eyes. - Added contribution guidelines, including information regarding the CLA. - Merged in [Pascal Borreli's typo fix](#6) for "HTTPTransaction". Closes #10 Github Author: Adam McArthur <[email protected]> {sync, type="child", parent="github", parentrepo="facebook/proxygen", parentprnum="10", parentprfbid="353515734828382"} Test Plan: review Reviewed By: [email protected] Subscribers: doug, bmatheny FB internal diff: D1666829 Signature: t1:1666829:1415382090:87ffd769d8e7215acde01969c0b13ec48fb135e1
rezacute
pushed a commit
to rezacute/proxygen
that referenced
this pull request
Nov 9, 2014
Add wget as a dependency Summary: Closes facebook#5 Github Author: Gabriele Carrettoni <[email protected]> {sync, type="child", parent="github", parentrepo="facebook/proxygen", parentprnum="5", parentprfbid="900693103276440"} Reviewers: dcsommer Reviewed By: dcsommer Guard against older versions of OpenSSL Summary: ServerNameCallbackResult isn't always defined by thrift if the OpenSSL version is too old. Test Plan: HHVM OSS build Reviewers: dcsommer, afrind Reviewed By: afrind Allow building without gflags Summary: NO_LIB_GFLAGS is a define we've used elsewhere to deal with not having gflags on the local system Test Plan: HHVM OSS build Reviewers: dcsommer, afrind Reviewed By: afrind revert the window update diff Reviewed By: dcsommer Add cancel to error enum Reviewers: seanc, ranjeeth, dcsommer, subodh Reviewed By: subodh Use static buffer for mobile builds Build system improvements. Summary: Separate dependency fetching + building from installing. Closes facebook#8 Github Author: Daniel Sommermann <[email protected]> {sync, type="child", parent="github", parentrepo="facebook/proxygen", parentprnum="8", parentprfbid="843969238967487"} Test Plan: unit tests. tested on my laptop. Reviewers: davejwatson, viswanath, praveenr Reviewed By: praveenr Update README.md with blog post link Reviewed By: cgheorghe Build system improvements. Summary: Separate dependency fetching + building from installing. Closes facebook#8 Github Author: Daniel Sommermann <[email protected]> {sync, type="child", parent="github", parentrepo="facebook/proxygen", parentprnum="8", parentprfbid="843969238967487"} Test Plan: unit tests Reviewers: davejwatson, viswanath, praveenr Reviewed By: praveenr Fixed minor typo Summary: Closes facebook#6 Github Author: Pascal Borreli <[email protected]> {sync, type="child", parent="github", parentrepo="facebook/proxygen", parentprnum="6", parentprfbid="822211311176446"} Test Plan: Imported from GitHub, without a `Test Plan:` line. Reviewers: viswanath, afrind, cgheorghe, praveenr Reviewed By: praveenr Make reinstall load the libraries up Summary: This tripped up some people Test Plan: live Reviewed By: [email protected] Blame Rev: Update README Summary: - Moved directory explanation list into a table. Easier on the eyes. - Added contribution guidelines, including information regarding the CLA. - Merged in [Pascal Borreli's typo fix](facebook#6) for "HTTPTransaction". Closes facebook#10 Github Author: Adam McArthur <[email protected]> {sync, type="child", parent="github", parentrepo="facebook/proxygen", parentprnum="10", parentprfbid="353515734828382"} Test Plan: review Reviewed By: [email protected] Subscribers: doug, bmatheny FB internal diff: D1666829 Signature: t1:1666829:1415382090:87ffd769d8e7215acde01969c0b13ec48fb135e1 Bump version to 1:0
ghost
pushed a commit
that referenced
this pull request
May 30, 2016
Summary: Diff #6 of 14. Reviewed By: mzlee Differential Revision: D3186908 fbshipit-source-id: 1e739b104b7dbffadfd4ffe6695953a1ce1ae558
This was referenced May 17, 2017
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 8, 2018
Summary:
Exposed by UBSAN:
```lang=bash
proxygen/lib/http/codec/SPDYConstants.cpp:67:11: runtime error: load of value 314159, which is not a valid value for type 'proxygen::spdy::ResetStatusCode'
#0 0x7f81bb4b39d9 in proxygen::spdy::rstToErrorCode(proxygen::spdy::ResetStatusCode) proxygen/lib/http/codec/SPDYConstants.cpp:67
#1 0x7f81bb443d31 in proxygen::SPDYCodec::onRstStream(unsigned int) proxygen/lib/http/codec/SPDYCodec.cpp:1331
#2 0x7f81bb43f559 in proxygen::SPDYCodec::onControlFrame(folly::io::Cursor&) proxygen/lib/http/codec/SPDYCodec.cpp:376
#3 0x7f81bb43c305 in proxygen::SPDYCodec::parseIngress(folly::IOBuf const&) proxygen/lib/http/codec/SPDYCodec.cpp:309
#4 0x7f81bb43a4ec in proxygen::SPDYCodec::onIngress(folly::IOBuf const&) proxygen/lib/http/codec/SPDYCodec.cpp:243
#5 0x7f81cdf12854 in proxygen::PassThroughHTTPCodecFilter::onIngress(folly::IOBuf const&) proxygen/lib/http/codec/HTTPCodecFilter.cpp:170
#6 0x7f81cdf12854 in proxygen::PassThroughHTTPCodecFilter::onIngress(folly::IOBuf const&) proxygen/lib/http/codec/HTTPCodecFilter.cpp:170
#7 0x7f81cdf12854 in proxygen::PassThroughHTTPCodecFilter::onIngress(folly::IOBuf const&) proxygen/lib/http/codec/HTTPCodecFilter.cpp:170
#8 0x7f81cdf12854 in proxygen::PassThroughHTTPCodecFilter::onIngress(folly::IOBuf const&) proxygen/lib/http/codec/HTTPCodecFilter.cpp:170
#9 0x7f81d0da0239 in proxygen::HTTPSession::processReadData() proxygen/lib/http/session/HTTPSession.cpp:487
#10 0x7f81d0d9fe39 in proxygen::HTTPSession::readDataAvailable(unsigned long) proxygen/lib/http/session/HTTPSession.cpp:440
#11 0x7f81e6daea85 in folly::AsyncSocket::handleRead() folly/io/async/AsyncSocket.cpp:1900
#12 0x7f81e6da93f9 in folly::AsyncSocket::ioReady(unsigned short) folly/io/async/AsyncSocket.cpp:1694
#13 0x7f81e6dc14ee in folly::AsyncSocket::IoHandler::handlerReady(unsigned short) folly/io/async/AsyncSocket.h:976
#14 0x7f81e6e5e91b in folly::EventHandler::libeventCallback(int, short, void*) folly/io/async/EventHandler.cpp:160
#15 0x7f81de739b11 in event_process_active /home/engshare/third-party2/libevent/1.4.14b_hphp/src/libevent-1.4.14b-stable/event.c:390
#16 0x7f81de739b11 in event_base_loop /home/engshare/third-party2/libevent/1.4.14b_hphp/src/libevent-1.4.14b-stable/event.c:532
#17 0x7f81e6e11864 in folly::EventBase::loopBody(int) folly/io/async/EventBase.cpp:313
#18 0x7f81e6e10726 in folly::EventBase::loop() folly/io/async/EventBase.cpp:252
#19 0x7f81e6e14e85 in folly::EventBase::loopForever() folly/io/async/EventBase.cpp:450
#20 0x7f81c4141a7b in proxygen::WorkerThread::runLoop() proxygen/lib/services/WorkerThread.cpp:137
#21 0x7f81c4143afe in proxygen::WorkerThread::start()::$_0::operator()() proxygen/lib/services/WorkerThread.cpp:41
#22 0x7f81c4143a34 in void std::_Bind_simple<proxygen::WorkerThread::start()::$_0 ()>::_M_invoke<>(std::_Index_tuple<>) third-party-buck/gcc-5-glibc-2.23/build/libgcc/include/c++/trunk/functional:1530
#23 0x7f81c4143a04 in std::_Bind_simple<proxygen::WorkerThread::start()::$_0 ()>::operator()() third-party-buck/gcc-5-glibc-2.23/build/libgcc/include/c++/trunk/functional:1520
#24 0x7f81c41438d8 in std::thread::_Impl<std::_Bind_simple<proxygen::WorkerThread::start()::$_0 ()> >::_M_run() third-party-buck/gcc-5-glibc-2.23/build/libgcc/include/c++/trunk/thread:115
#25 0x7f81da7ef170 in execute_native_thread_routine /home/engshare/third-party2/libgcc/5.x/src/gcc-5/x86_64-facebook-linux/libstdc++-v3/src/c++11/../../../.././libstdc++-v3/src/c++11/thread.cc:84
#26 0x7f81d7e1f7a8 in start_thread /home/engshare/third-party2/glibc/2.23/src/glibc-2.23/nptl/pthread_create.c:333
#27 0x7f81d71f9a7c in __clone /home/engshare/third-party2/glibc/2.23/src/glibc-2.23/misc/../sysdeps/unix/sysv/linux/x86_64/clone.S:109
SUMMARY: UndefinedBehaviorSanitizer: invalid-enum-load proxygen/lib/http/codec/SPDYConstants.cpp:67:11
```
Here we have a typical function that converts from one enum type to another. There is a special validation logic in place, if the original enum value is not among predetermined values the result is a "special" error value. UBSAN detected that the argumemnt value which was provided was invalid for the original enum type. To prevent the UB and potential overflow use an int type.
Reviewed By: w-o-o
Differential Revision: D7185566
fbshipit-source-id: 613c8c6aa64d24c48889810e56a79fd370cdb32b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.