Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in props listings don't look like links #1831

Closed
rachelnabors opened this issue Apr 8, 2020 · 5 comments
Closed

Links in props listings don't look like links #1831

rachelnabors opened this issue Apr 8, 2020 · 5 comments

Comments

@rachelnabors
Copy link
Contributor

See also the prop definitions for Color: image originally posted by @TheSavior in #1813 (comment)

@Simek
Copy link
Collaborator

Simek commented Apr 8, 2020

I'm on it.

@elicwhite
Copy link
Member

Woah, I tried tapping on those a bunch of times on mobile and was positive they weren't links. They probably need much larger hitboxes.

Screen Shot 2020-04-08 at 11 31 49 AM

@Simek
Copy link
Collaborator

Simek commented Apr 8, 2020

Not every color type keyword is linked unfortunately, my PR should make obvious which currently are.

I can add padding to the links inside table, but other links on the website has no padding. I have no issues on desktop. Do you have problem with other, in text, links on mobile?

Maybe we should adjust all links padding but only on mobile?

@elicwhite
Copy link
Member

I haven't used the docs much to know if i have problem with other text links on mobile. I probably gave up quicker because of the styling. So it is possible that your styling fixes will solve this.

@rachelnabors
Copy link
Contributor Author

Styling issue fixed in #1832

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants