Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DynamicColorIOS to its own page #1850

Closed
rachelnabors opened this issue Apr 14, 2020 · 2 comments · Fixed by #1851
Closed

Move DynamicColorIOS to its own page #1850

rachelnabors opened this issue Apr 14, 2020 · 2 comments · Fixed by #1851
Assignees
@rachelnabors

Comments

@rachelnabors
Copy link
Contributor

When we documentated the PlatformColor API, it came to light that DynamicColorIOS needs its own page. For now it lives on the Colors page. Move it into the API section of the site, reference it from the colors page and PlatformColor, and add an example
@rachelnabors rachelnabors added the 👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Apr 14, 2020
@rachelnabors rachelnabors mentioned this issue Apr 16, 2020
Merged
@Simek Simek linked a pull request Apr 16, 2020 that will close this issue
DynamicColorsIOS page #1851
Merged
@mitulsavani
Copy link
Contributor

mitulsavani commented Apr 19, 2020 •
edited
Loading

Hi @rachelnabors,

I was able to read a full conversation regarding this issue. I am curious if @kikisaints is already working on it? If not, then can I give it a shot.

@Simek Simek assigned Simek and rachelnabors and unassigned Simek Apr 20, 2020
@Simek Simek removed the 👋 Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Apr 20, 2020
@Simek
Copy link
Collaborator

Simek commented Apr 20, 2020 •
edited
Loading

Hi @mitulsavani, unfortunately the changes requested in this issue has been already proposed.

As the issue actions log shows, there is a PR by Rachel linked to this issue which extracts DynamicColorIOS API and introduces few other changes.

If you are interested in contributing, there are few other Good first issues and most wanted for now is #1509.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rachelnabors rachelnabors

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DynamicColorsIOS page rachelnabors/react-native-website
3 participants
@rachelnabors @Simek @mitulsavani