Skip to content

Commit

Permalink
Fix IllegalStateException when tapping next on Android Keyboard
Browse files Browse the repository at this point in the history
Summary: This diff fixes an IllegalStateException that is thrown when the user click is on a edit text and tap 'Next' on the keyboard to focus on the next view, but the next view is hidden.

Reviewed By: lunaleaps, mmmulani

Differential Revision: D14598410

fbshipit-source-id: 2999cc468ed24bedff163eedcfaec50f6ee005d6
  • Loading branch information
mdvacca authored and kelset committed Mar 29, 2019
1 parent 775553b commit 13cb5a9
Showing 1 changed file with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

package com.facebook.react.views.textinput;

import static android.view.View.FOCUS_FORWARD;

import android.annotation.TargetApi;
import android.graphics.PorterDuff;
import android.graphics.Typeface;
Expand Down Expand Up @@ -882,6 +884,12 @@ public boolean onEditorAction(TextView v, int actionId, KeyEvent keyEvent) {

// Prevent default behavior except when we want it to insert a newline.
return blurOnSubmit || !isMultiline;
} else if (actionId == EditorInfo.IME_ACTION_NEXT) {
View v1 = v.focusSearch(FOCUS_FORWARD);
if (v1 != null && !v.requestFocus(FOCUS_FORWARD)) {
return true;
}
return false;
}

return true;
Expand Down

0 comments on commit 13cb5a9

Please sign in to comment.