Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Systrace markers not visible for JS threads. #14394

Closed
jayshah123 opened this issue Jun 8, 2017 · 5 comments
Closed

[Android] Systrace markers not visible for JS threads. #14394

jayshah123 opened this issue Jun 8, 2017 · 5 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@jayshah123
Copy link
Contributor

jayshah123 commented Jun 8, 2017

Checking as of RN 0.44, Checked with all android OS, and with both emulator and device,
there are no systrace markers visible for JS thread.

Systrace is recorded using the command provided in docs link [Also tried with Android monitor, same results]

The systrace looks like :
androidsystraceproblem

The green line above is mqt_js thread.

What I tried

On checking more the systraces are present, but seem to be opted out behind the feature flag -> WITH_FBSYSTRACE.

I tried to build code from from source turning on WITH_FBSYSTRACE, build fails as it is not able to find the fbsystrace.h header.

References

What else can be done to see the systrace markers for JS thread execution ? This has previously been closed without any answer in #9111, and a different case where tyring to use Systrace.js API on android throws (#9349)

Is it possible to get traces as mentioned here #11809 (comment) (It also shows lifecycle times).

Additional Information

  • React Native version: RN0.44
  • Platform: Android
  • Development Operating System: macOS
  • Dev tools: Android Studio, Android SDK all versions
@jayshah123
Copy link
Contributor Author

Many of performance issues I want to investigate are unique to android, and systrace is an invaluable tool to narrow down the root cause.
Any ideas what else can be tried to make systrace work? @astreet

@jayshah123
Copy link
Contributor Author

Some previous failed attempt to do the same was in #10944

@jayshah123
Copy link
Contributor Author

jayshah123 commented Aug 14, 2017

Looks like as per comment in #15003 (comment) C++ bridge depends on fbsystrace which is not opensource, so there's that.
For a long shot, Looks like replacing fbsystrace with android native atrace, but is nontrivial and not supported pre api level 23.

@pull-bot
Copy link

@facebook-github-bot no-template

@facebook-github-bot
Copy link
Contributor

Hey, thanks for reporting this issue! It looks like your description is missing some necessary information, or the list of reproduction steps is not complete. Can you please add all the details specified in the Issue Template? This is necessary for people to be able to understand and reproduce the issue being reported. I am going to close this, but feel free to open a new issue with the additional information provided. Thanks! See "What to Expect from Maintainers" to learn more.

@facebook-github-bot facebook-github-bot added the Ran Commands One of our bots successfully processed a command. label Oct 10, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Oct 10, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants