-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Systrace markers not visible for JS threads. #14394
Comments
Many of performance issues I want to investigate are unique to android, and systrace is an invaluable tool to narrow down the root cause. |
Some previous failed attempt to do the same was in #10944 |
Looks like as per comment in #15003 (comment) C++ bridge depends on fbsystrace which is not opensource, so there's that. |
@facebook-github-bot no-template |
Hey, thanks for reporting this issue! It looks like your description is missing some necessary information, or the list of reproduction steps is not complete. Can you please add all the details specified in the Issue Template? This is necessary for people to be able to understand and reproduce the issue being reported. I am going to close this, but feel free to open a new issue with the additional information provided. Thanks! See "What to Expect from Maintainers" to learn more. |
Checking as of RN 0.44, Checked with all android OS, and with both emulator and device,
there are no systrace markers visible for JS thread.
Systrace is recorded using the command provided in docs link [Also tried with Android monitor, same results]
The systrace looks like :
The green line above is mqt_js thread.
What I tried
On checking more the systraces are present, but seem to be opted out behind the feature flag -> WITH_FBSYSTRACE.
I tried to build code from from source turning on WITH_FBSYSTRACE, build fails as it is not able to find the fbsystrace.h header.
References
What else can be done to see the systrace markers for JS thread execution ? This has previously been closed without any answer in #9111, and a different case where tyring to use Systrace.js API on android throws (#9349)
Is it possible to get traces as mentioned here #11809 (comment) (It also shows lifecycle times).
Additional Information
The text was updated successfully, but these errors were encountered: