Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with FileProvider (Android) globally within React Native and libraries #14615

Closed
iremlopsum opened this issue Jun 19, 2017 · 3 comments
Closed
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@iremlopsum
Copy link

Description

If I want to have two libraries, for example Image Picker and Doc Viewer. They both have their own AndroidManifest file that defines a provider with android:name="android.support.v4.content.FileProvider". Which causes an issue because it can't be defined multiple times and it causes a merge issue. As I understand, this needs to be defined globally.

What is the recommended way of dealing with this, so that I as a user can define those things globally and libraries still can give me access to FileProvider?

Additional Information

  • React Native version: 0.45.1,
  • Platform: Android
  • Development Operating System:Windows
@hey99xx
Copy link

hey99xx commented Jun 20, 2017

I think the libraries should be updated to use unique names. See https://stackoverflow.com/questions/43175014/possible-to-use-multiple-authorities-with-fileprovider

@iremlopsum
Copy link
Author

@hey99xx this is interesting. I currently am stuck with how to approach it. I probably should just fork the libraries and use them as local modules, but this doesn't seem like a scaleable model

@hramos hramos added the Icebox label Aug 24, 2017
@hramos
Copy link
Contributor

hramos commented Aug 24, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos closed this as completed Aug 24, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Aug 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

4 participants