Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native TextInput in ListView value by state is stuck #14651

Closed
rexjrs opened this issue Jun 21, 2017 · 3 comments
Closed

React Native TextInput in ListView value by state is stuck #14651

rexjrs opened this issue Jun 21, 2017 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@rexjrs
Copy link

rexjrs commented Jun 21, 2017

Description

State value locks up when scrolling down a ListView and coming back up. I think the Optimization techniques where rows out of screen view "unrender themselves" of the ListView component messes up the TextInput's value property and locks up.

This describes what I mean.

https://www.youtube.com/watch?v=fq7ITtzRvg4&feature=youtu.be

Reproduction Steps

Set up a listview with some data. Set up a TextInput with dynamic state value property and onChangeText

Sample Code

                            <TextInput
                                style={styles.commentInput}
                                placeholder="Say something..."
                                placeholderTextColor="gray"
                                underlineColorAndroid="transparent"
                                multiline={true}
                                blurOnSubmit={true}
                                value={this.state["row"+data.id]}
                                onChangeText={(input) => {this.setState({["row"+data.id]: input})}}
                            />

See here for full code snippet:
https://stackoverflow.com/questions/44666538/react-native-listview-textinput-locks-up-from-performance-optimization-rendering

Additional Information

  • React Native version: 0.45.1
  • Platform: [FILL THIS OUT: Android confirmed. Maybe IOS?EDIT: BOTH confirmed
  • Development Operating System: [FILL THIS OUT: MAC
@rexjrs
Copy link
Author

rexjrs commented Jun 27, 2017

I've been stuck on this for a week. Anyone got any comments?

@hramos
Copy link
Contributor

hramos commented Jul 7, 2017

Does this still reproduce within a FlatList? ListView is deprecated.

@hramos hramos added the Icebox label Sep 21, 2017
@hramos
Copy link
Contributor

hramos commented Sep 21, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos closed this as completed Sep 21, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Sep 21, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants