Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Android) textDecorationLine style doesn't update after removed in Text inside a Textinput #18286

Closed
elliscwc opened this issue Mar 9, 2018 · 5 comments
Labels
Component: TextInput Related to the TextInput component. Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@elliscwc
Copy link

elliscwc commented Mar 9, 2018

After applying textDecorationLine style into a Text component that is inside a TextInput component, removing the style doesn't remove the visual effect. This applies to underline and line-through or both.

<TextInput>
  <Text style={{textDecorationLine: 'line-through'}} />
</TextInput>

Environment

Environment:
  OS: macOS High Sierra 10.13.3
  Node: 9.3.0
  Yarn: 1.3.2
  npm: 5.6.0
  Watchman: 4.9.0
  Xcode: Xcode 9.2 Build version 9C40b
  Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
  react: 16.2.0 => 16.2.0
  react-native: 0.53.2 => 0.53.2

Expected Behavior

Removing the textDecorationLine style applied into the text should remove the text effect.

Actual Behavior

Apply textDecorationLine style, then remove it. The underline and line-through effects are still there.

Steps to Reproduce

https://snack.expo.io/Hkjuj2JYz

  1. Open the expo
  2. Press the buttons to toggle the styles to see the issue
@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like your issue may refer to an older version of React Native. Can you reproduce the issue on the latest stable release?

Thank you for your contributions.

How to ContributeWhat to Expect from Maintainers

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. Old Version Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. and removed Old Version labels Mar 9, 2018
@elliscwc
Copy link
Author

Environment:
  OS: macOS High Sierra 10.13.3
  Node: 9.3.0
  Yarn: 1.3.2
  npm: 5.6.0
  Watchman: 4.9.0
  Xcode: Xcode 9.2 Build version 9C40b
  Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
  react: 16.2.0 => 16.2.0
  react-native: 0.54 => 0.54.0

Tested in latest stable release, still it can be repro'd.

@elliscwc
Copy link
Author

@react-native-bot could you update the labels? thanks!

@react-native-bot react-native-bot added Android Ran Commands One of our bots successfully processed a command. Component: TextInput Related to the TextInput component. labels Mar 13, 2018
@react-native-bot react-native-bot added Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. labels Mar 18, 2018
@react-native-bot react-native-bot added the Platform: macOS Building on macOS. label Mar 20, 2018
@hramos hramos removed the Platform: macOS Building on macOS. label Mar 29, 2018
@AndreiCalazans
Copy link
Contributor

AndreiCalazans commented May 15, 2018

Environment:
OS: macOS High Sierra 10.13.4
Node: 9.4.0
Yarn: 1.3.2
npm: 5.6.0
Watchman: 4.7.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 2.3 AI-162.4069837

Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: 0.55.1 => 0.55.1

same thing here, I'm on the newest version of RN.

@elliscwc any work around with this?
It works with <Text /> if you place it outside the <TextInput />

@react-native-bot
Copy link
Collaborator

I am closing this issue because it does not appear to have been verified on the latest release, and there has been no followup in a while.

If you found this thread after encountering the same issue in the latest release, please feel free to create a new issue with up-to-date information by clicking here.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 18, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: TextInput Related to the TextInput component. Issue: Author Provided Repro This issue can be reproduced in Snack or an attached project. Platform: Android Android applications. Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants