[Node 10] Prepare for Node 10

[hramos]

For Discussion

Node 10 is the current Node version as of this writing. While the project requires a minimum of Node 8, we should make sure Node 10 is well supported.

Things that need to be done:

• Ensure tests can run on Node 10 (The module factory of jest.mock() is not allowed to reference any out-of-scope variables. #19120)
• Test with Node 10

cc @ide, @TheSavior, @grabbou

Environment

N/A

Steps to Reproduce

N/A

Expected Behavior

N/A

Actual Behavior

N/A

[react-native-bot]

Thanks for posting this! It looks like your issue may be missing some necessary information. Can you run react-native info and edit your issue to include these results under the Environment section?

Thank you for your contributions.

[gengjiawen]

How about a new docker image instead of circle ci ?

[hramos]

We'll likely add a new workflow to run tests on Node 10 alongside the current Node 8 tests. It should be pretty straightforward to get that working, though we don't want to enable that on master until it's green.

[gengjiawen]

I also want to keep node 8 along side with node 10. I just think circle official node image not suitable for react native. The node 10 image will use reactnativeci/android as base image.

[hramos]

What's special about Node 10 that would not work on Circle? What I have in mind is something close to what we already have set up on Circle, but using Node 10 instead. You can see an example here: #19299

It's only testing JavaScript at the moment, but it could be expanded to run all tests in Node 10 in parallel as well (i.e. build the JS bundle using Node 10 and pass that along to test_android).

Note that the build in that PR is failing because test_javascript was failing on master using Node 8 as well.

[gengjiawen]

My thought is that the node 10 will bundle android related library so we just use one image. And also the image can be used by community for their ci system, which I think will save lots time.

[gengjiawen]

Also I have some idea simpilify current ci, like avoid setup avd by using more docker.

[hramos]

Most of the work required to get that working is already in place. Take a look at the docker scripts here. You may need to rebuild the images locally as I am not yet automatically pushing new images to Docker Hub at the moment. I last gave this a try about a week ago and I believe I was blocked on one of the buck failures that was plaguing master. Once we get test_android working again, it should be possible to get that image to work within Circle CI.

[hramos]

You may need to update some of the Dockerfiles in the Containership directory, especially now that we've been bumping SDK versions.

[martabacc]

hi @gengjiawen , want to ask, why you specifically choose for node 8, not node 9?

One of my project is using react-native 0.4xx version, and we cannot run test/build using node 9, it's only works on node 8. Sort of confusing since both are unrelated directly (node and react-native).

Do you have any idea about this?

[fendorio]

@ronayumik I suspect it is related to the fact that node 9.x line will never enter a Long Term Support state (LTS), and is scheduled to reach end-of-life (EOL) shortly after Node 10 is released.

[gengjiawen]

@ronayumik Can you try node 10 ?
@hramos I have add node 10 to appveyor.yml.

[hramos]

We have been running tests using Node 10 for a while now.