Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ART: Shape doesn't apply opacity when fill are LinearGradient (Android only) #20383

Closed
2 of 3 tasks
ikhilko opened this issue Jul 25, 2018 · 3 comments
Closed
2 of 3 tasks
Labels
Platform: Android Android applications. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@ikhilko
Copy link

ikhilko commented Jul 25, 2018

Environment:

OS: macOS High Sierra 10.13.6
Node: 9.11.1
Yarn: 1.7.0
npm: 5.6.0
Watchman: 4.9.0
Xcode: Xcode 9.4.1 Build version 9F2000
Android Studio: 3.1 AI-173.4819257

Packages: (wanted => installed)
react: 16.3.1 => 16.3.1
react-native: expo/react-native#sdk-28.0.1 => 0.55.4

Description

ARTShape doesn't apply opacity on Android when fill type is LinearGradient. Worked pretty well on iOS.

Reproducible Demo

I prepared a demo showing this problem: https://snack.expo.io/@ikhilko/artshape-opacity-bug-while-using-lineargradient-fill

@react-native-bot react-native-bot added the Platform: Android Android applications. label Jul 25, 2018
@ikhilko
Copy link
Author

ikhilko commented Jul 25, 2018

I hope issue can be fixed in one line of code in this file. Looks like it should be:
int a = (int) (255 * mBrushData[5 + 4*i + 3] * opacity);

Maybe someone can check it and add a PR?

@stale
Copy link

stale bot commented Oct 23, 2018

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 23, 2018
@stale
Copy link

stale bot commented Oct 30, 2018

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Oct 30, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Platform: Android Android applications. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

2 participants