Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safearea not support iphone xs max #21171

Closed
3 tasks done
joe-lz opened this issue Sep 18, 2018 · 13 comments
Closed
3 tasks done

safearea not support iphone xs max #21171

joe-lz opened this issue Sep 18, 2018 · 13 comments
Labels
JavaScript Resolution: Locked This issue was locked by the bot.

Comments

@joe-lz
Copy link

joe-lz commented Sep 18, 2018

Environment

React Native Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Memory: 1.11 GB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 8.11.2 - /usr/local/bin/node
Yarn: 1.7.0 - /usr/local/bin/yarn
npm: 5.6.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
IDEs:
Android Studio: 3.1 AI-173.4819257
Xcode: 10.0/10A255 - /usr/bin/xcodebuild
npmPackages:
react: 16.5.0 => 16.5.0
react-native: 0.57.0 => 0.57.0
npmGlobalPackages:
create-react-native-app: 1.0.0
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7

Description

2018-09-18 10 27 26

@jordanmkoncz
Copy link

It will most likely be broken for both the iPhone XS Max and iPhone XR, which both have a new Native Resolution / Physical Size (1242px x 2688px and 828px x 1792px, respectively) and a new UIKit Size / Screen Size (414pt x 896pt for both).

See:

@vonovak
Copy link
Contributor

vonovak commented Sep 19, 2018

maybe related #20999

@hagaigold
Copy link

@jeodiong, Is this react-navigation screen ?
if so, it is different safe-area implementation from react-native SafeAreaView.

@SNNikitin
Copy link

I have similar issue
Maybe it's something like this react-navigation/react-navigation#4985 ?

@joe-lz
Copy link
Author

joe-lz commented Sep 19, 2018

image
both not working

@joe-lz
Copy link
Author

joe-lz commented Sep 20, 2018

react-navigation/react-navigation#4985 (comment)

@RenderCoder
Copy link

I use react-native-safe-area-view solve this problem.

replace import { SafeAreaView } from 'react-navigation' to import { SafeAreaView } from "react-native-safe-area-view"

@joe-lz
Copy link
Author

joe-lz commented Sep 20, 2018

@bijiabo new version of react-navigation works fine with iphone xs max

@RenderCoder
Copy link

@bijiabo new version of react-navigation works fine with iphone xs max

Yes, my scene is our project is using a old version and have added many logic about router on it. So we'd like not to update it.

@ducpt2
Copy link

ducpt2 commented Oct 1, 2018

@jeodiong in my case, it only work on iphone X,
on Xs max, it not work.
react-navigation 2.17.0

@MaheshNandam
Copy link

Moving to 2.17.0 works for me

@ducpt2
Copy link

ducpt2 commented Oct 8, 2018

@MaheshNandam what is your native base version? My version is:
"native-base": "2.4.5"
"react-navigation": "2.17.0"

Thanks

@MaheshNandam
Copy link

hey @ducpt2, I'm not using native base.

@facebook facebook locked as resolved and limited conversation to collaborators Sep 20, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
JavaScript Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

10 participants