-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Add Node 10 job to workflow #19299
Conversation
Jest need to make a new release to support node 10, jestjs/jest#6196. |
@hramos I tried to find reviewers for this pull request and wanted to ping them to take another look. However, based on the blame information for the files in this pull request I couldn't find any reviewers. This sometimes happens when the files in the pull request are new or don't exist on master anymore. Is this pull request still relevant? If yes could you please rebase? In case you know who has context on this code feel free to mention them in a comment (one person is fine). Thanks for reading and hope you will continue contributing to the project. |
Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours has expired. Before we can review or merge your code, we need you to email [email protected] with your details so we can update your status. |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This pull request was closed by @hramos in 91bba30. Once this commit is added to a release, you will see the corresponding version tag below the description at 91bba30. If the commit has a single |
Summary: Pull Request resolved: #19299 Differential Revision: D9413583 Pulled By: hramos fbshipit-source-id: 61ac48e46feaba5f1ec80362b5e1c7f2787ee167
Summary: Pull Request resolved: facebook#19299 Differential Revision: D9413583 Pulled By: hramos fbshipit-source-id: 61ac48e46feaba5f1ec80362b5e1c7f2787ee167
Summary: Pull Request resolved: facebook#19299 Differential Revision: D9413583 Pulled By: hramos fbshipit-source-id: 61ac48e46feaba5f1ec80362b5e1c7f2787ee167
Summary: Pull Request resolved: facebook#19299 Differential Revision: D9413583 Pulled By: hramos fbshipit-source-id: 61ac48e46feaba5f1ec80362b5e1c7f2787ee167
Adds a new workflow that runs JavaScript tests on Node 10. Fixes #19229.