Skip to content

Commit

Permalink
Enabled Profiling feature flags for OSS release (#21565)
Browse files Browse the repository at this point in the history 
* Enabled Profiling feature flags for OSS release

`enableProfilerCommitHooks` and `enableProfilerNestedUpdatePhase`
  • Loading branch information
Brian Vaughn authored May 25, 2021
1 parent 0ae5290 commit 6405efc
Show file tree
Hide file tree
Showing 8 changed files with 40 additions and 40 deletions.
52 changes: 26 additions & 26 deletions packages/react-devtools-shared/src/__tests__/__snapshots__/profilingCache-test.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ Object {
},
},
"duration": 3,
"effectDuration": null,
"effectDuration": 0,
"fiberActualDurations": Map {
7 => 3,
3 => 3,
Expand All @@ -122,7 +122,7 @@ Object {
7 => 3,
3 => 0,
},
"passiveEffectDuration": null,
"passiveEffectDuration": 0,
"priorityLevel": "Immediate",
"timestamp": 18,
"updaters": Array [
Expand Down Expand Up @@ -286,7 +286,7 @@ Object {
},
},
"duration": 10,
"effectDuration": null,
"effectDuration": 0,
"fiberActualDurations": Map {
4 => 0,
2 => 10,
Expand All @@ -297,7 +297,7 @@ Object {
2 => 10,
1 => 0,
},
"passiveEffectDuration": null,
"passiveEffectDuration": 0,
"priorityLevel": "Immediate",
"timestamp": 35,
"updaters": Array [
Expand Down Expand Up @@ -326,7 +326,7 @@ Object {
},
},
"duration": 10,
"effectDuration": null,
"effectDuration": 0,
"fiberActualDurations": Map {
2 => 10,
1 => 10,
Expand All @@ -335,7 +335,7 @@ Object {
2 => 10,
1 => 0,
},
"passiveEffectDuration": null,
"passiveEffectDuration": 0,
"priorityLevel": "Immediate",
"timestamp": 45,
"updaters": Array [
Expand Down Expand Up @@ -587,7 +587,7 @@ Object {
],
],
"duration": 10,
"effectDuration": null,
"effectDuration": 0,
"fiberActualDurations": Array [
Array [
4,
Expand Down Expand Up @@ -616,7 +616,7 @@ Object {
0,
],
],
"passiveEffectDuration": null,
"passiveEffectDuration": 0,
"priorityLevel": "Immediate",
"timestamp": 35,
"updaters": Array [
Expand Down Expand Up @@ -645,7 +645,7 @@ Object {
],
],
"duration": 10,
"effectDuration": null,
"effectDuration": 0,
"fiberActualDurations": Array [
Array [
2,
Expand All @@ -666,7 +666,7 @@ Object {
0,
],
],
"passiveEffectDuration": null,
"passiveEffectDuration": 0,
"priorityLevel": "Immediate",
"timestamp": 45,
"updaters": Array [
Expand Down Expand Up @@ -1367,7 +1367,7 @@ Object {
},
},
"duration": 10,
"effectDuration": null,
"effectDuration": 0,
"fiberActualDurations": Map {
4 => 0,
2 => 10,
Expand All @@ -1378,7 +1378,7 @@ Object {
2 => 10,
1 => 0,
},
"passiveEffectDuration": null,
"passiveEffectDuration": 0,
"priorityLevel": "Immediate",
"timestamp": 34,
"updaters": Array [
Expand All @@ -1404,7 +1404,7 @@ Object {
},
},
"duration": 10,
"effectDuration": null,
"effectDuration": 0,
"fiberActualDurations": Map {
2 => 10,
1 => 10,
Expand All @@ -1413,7 +1413,7 @@ Object {
2 => 10,
1 => 0,
},
"passiveEffectDuration": null,
"passiveEffectDuration": 0,
"priorityLevel": "Immediate",
"timestamp": 44,
"updaters": Array [
Expand Down Expand Up @@ -1683,10 +1683,10 @@ Object {
Object {
"changeDescriptions": Map {},
"duration": 0,
"effectDuration": null,
"effectDuration": 0,
"fiberActualDurations": Map {},
"fiberSelfDurations": Map {},
"passiveEffectDuration": null,
"passiveEffectDuration": 0,
"priorityLevel": "Normal",
"timestamp": 34,
"updaters": Array [
Expand Down Expand Up @@ -1900,7 +1900,7 @@ Object {
],
],
"duration": 10,
"effectDuration": null,
"effectDuration": 0,
"fiberActualDurations": Array [
Array [
4,
Expand Down Expand Up @@ -1929,7 +1929,7 @@ Object {
0,
],
],
"passiveEffectDuration": null,
"passiveEffectDuration": 0,
"priorityLevel": "Immediate",
"timestamp": 34,
"updaters": Array [
Expand Down Expand Up @@ -1958,7 +1958,7 @@ Object {
],
],
"duration": 10,
"effectDuration": null,
"effectDuration": 0,
"fiberActualDurations": Array [
Array [
2,
Expand All @@ -1979,7 +1979,7 @@ Object {
0,
],
],
"passiveEffectDuration": null,
"passiveEffectDuration": 0,
"priorityLevel": "Immediate",
"timestamp": 44,
"updaters": Array [
Expand Down Expand Up @@ -2306,10 +2306,10 @@ Object {
Object {
"changeDescriptions": Array [],
"duration": 0,
"effectDuration": null,
"effectDuration": 0,
"fiberActualDurations": Array [],
"fiberSelfDurations": Array [],
"passiveEffectDuration": null,
"passiveEffectDuration": 0,
"priorityLevel": "Normal",
"timestamp": 34,
"updaters": Array [
Expand Down Expand Up @@ -2494,7 +2494,7 @@ Object {
},
},
"duration": 0,
"effectDuration": null,
"effectDuration": 0,
"fiberActualDurations": Map {
1 => 0,
2 => 0,
Expand All @@ -2505,7 +2505,7 @@ Object {
2 => 0,
3 => 0,
},
"passiveEffectDuration": null,
"passiveEffectDuration": 0,
"priorityLevel": "Normal",
"timestamp": 0,
"updaters": Array [
Expand Down Expand Up @@ -2685,7 +2685,7 @@ Object {
],
],
"duration": 0,
"effectDuration": null,
"effectDuration": 0,
"fiberActualDurations": Array [
Array [
1,
Expand Down Expand Up @@ -2714,7 +2714,7 @@ Object {
0,
],
],
"passiveEffectDuration": null,
"passiveEffectDuration": 0,
"priorityLevel": "Normal",
"timestamp": 0,
"updaters": Array [
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/ReactFeatureFlags.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ export const warnAboutDeprecatedLifecycles = true;
export const enableProfilerTimer = __PROFILE__;

// Record durations for commit and passive effects phases.
export const enableProfilerCommitHooks = false;
export const enableProfilerCommitHooks = __PROFILE__;

// Phase param passed to onRender callback differentiates between an "update" and a "cascading-update".
export const enableProfilerNestedUpdatePhase = false;
export const enableProfilerNestedUpdatePhase = __PROFILE__;

// Profiler API accepts a function to be called when a nested update is scheduled.
// This callback accepts the component type (class instance or function) the update is scheduled for.
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/forks/ReactFeatureFlags.native-fb.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ import typeof * as ExportsType from './ReactFeatureFlags.native-fb';
export const enableDebugTracing = false;
export const enableSchedulingProfiler = false;
export const enableProfilerTimer = __PROFILE__;
export const enableProfilerCommitHooks = false;
export const enableProfilerNestedUpdatePhase = false;
export const enableProfilerCommitHooks = __PROFILE__;
export const enableProfilerNestedUpdatePhase = __PROFILE__;
export const enableProfilerNestedUpdateScheduledHook = false;
export const enableUpdaterTracking = false;
export const enableSuspenseServerRenderer = false;
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/forks/ReactFeatureFlags.native-oss.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export const enableSchedulingProfiler = false;
export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
export const warnAboutDeprecatedLifecycles = true;
export const enableProfilerTimer = __PROFILE__;
export const enableProfilerCommitHooks = false;
export const enableProfilerNestedUpdatePhase = false;
export const enableProfilerCommitHooks = __PROFILE__;
export const enableProfilerNestedUpdatePhase = __PROFILE__;
export const enableProfilerNestedUpdateScheduledHook = false;
export const enableUpdaterTracking = false;
export const enableSuspenseServerRenderer = false;
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/forks/ReactFeatureFlags.test-renderer.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export const enableSchedulingProfiler = false;
export const warnAboutDeprecatedLifecycles = true;
export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
export const enableProfilerTimer = __PROFILE__;
export const enableProfilerCommitHooks = false;
export const enableProfilerNestedUpdatePhase = false;
export const enableProfilerCommitHooks = __PROFILE__;
export const enableProfilerNestedUpdatePhase = __PROFILE__;
export const enableProfilerNestedUpdateScheduledHook = false;
export const enableUpdaterTracking = false;
export const enableSuspenseServerRenderer = false;
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/forks/ReactFeatureFlags.test-renderer.native.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export const enableSchedulingProfiler = false;
export const warnAboutDeprecatedLifecycles = true;
export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
export const enableProfilerTimer = __PROFILE__;
export const enableProfilerCommitHooks = false;
export const enableProfilerNestedUpdatePhase = false;
export const enableProfilerCommitHooks = __PROFILE__;
export const enableProfilerNestedUpdatePhase = __PROFILE__;
export const enableProfilerNestedUpdateScheduledHook = false;
export const enableUpdaterTracking = false;
export const enableSuspenseServerRenderer = false;
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export const enableSchedulingProfiler = false;
export const warnAboutDeprecatedLifecycles = true;
export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
export const enableProfilerTimer = __PROFILE__;
export const enableProfilerCommitHooks = false;
export const enableProfilerNestedUpdatePhase = false;
export const enableProfilerCommitHooks = __PROFILE__;
export const enableProfilerNestedUpdatePhase = __PROFILE__;
export const enableProfilerNestedUpdateScheduledHook = false;
export const enableUpdaterTracking = false;
export const enableSuspenseServerRenderer = false;
Expand Down
4 changes: 2 additions & 2 deletions packages/shared/forks/ReactFeatureFlags.testing.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ export const enableSchedulingProfiler = false;
export const warnAboutDeprecatedLifecycles = true;
export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
export const enableProfilerTimer = __PROFILE__;
export const enableProfilerCommitHooks = false;
export const enableProfilerNestedUpdatePhase = false;
export const enableProfilerCommitHooks = __PROFILE__;
export const enableProfilerNestedUpdatePhase = __PROFILE__;
export const enableProfilerNestedUpdateScheduledHook = false;
export const enableUpdaterTracking = false;
export const enableSuspenseServerRenderer = false;
Expand Down

0 comments on commit 6405efc

Please sign in to comment.