Skip to content

Commit

Permalink
Remove argument committedLanes from reappearLayoutEffects and recursi…
Browse files Browse the repository at this point in the history
…velyTraverseReappearLayoutEffects (#25080)
  • Loading branch information
sammy-SC authored Aug 11, 2022
1 parent 7a22727 commit 7bcc687
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 22 deletions.
11 changes: 0 additions & 11 deletions packages/react-reconciler/src/ReactFiberCommitWork.new.js
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,6 @@ function commitLayoutEffectOnFiber(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
} else {
Expand Down Expand Up @@ -2704,7 +2703,6 @@ function reappearLayoutEffects(
finishedRoot: FiberRoot,
current: Fiber | null,
finishedWork: Fiber,
committedLanes: Lanes,
// This function visits both newly finished work and nodes that were re-used
// from a previously committed tree. We cannot check non-static flags if the
// node was reused.
Expand All @@ -2719,7 +2717,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
// TODO: Check flags & LayoutStatic
Expand All @@ -2730,7 +2727,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);

Expand Down Expand Up @@ -2772,7 +2768,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);

Expand All @@ -2792,7 +2787,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
// TODO: Figure out how Profiler updates should work with Offscreen
Expand All @@ -2805,7 +2799,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);

Expand All @@ -2825,7 +2818,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
}
Expand All @@ -2835,7 +2827,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
break;
Expand All @@ -2846,7 +2837,6 @@ function reappearLayoutEffects(
function recursivelyTraverseReappearLayoutEffects(
finishedRoot: FiberRoot,
parentFiber: Fiber,
committedLanes: Lanes,
includeWorkInProgressEffects: boolean,
) {
// This function visits both newly finished work and nodes that were re-used
Expand All @@ -2865,7 +2855,6 @@ function recursivelyTraverseReappearLayoutEffects(
finishedRoot,
current,
child,
committedLanes,
childShouldIncludeWorkInProgressEffects,
);
child = child.sibling;
Expand Down
11 changes: 0 additions & 11 deletions packages/react-reconciler/src/ReactFiberCommitWork.old.js
Original file line number Diff line number Diff line change
Expand Up @@ -1099,7 +1099,6 @@ function commitLayoutEffectOnFiber(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
} else {
Expand Down Expand Up @@ -2704,7 +2703,6 @@ function reappearLayoutEffects(
finishedRoot: FiberRoot,
current: Fiber | null,
finishedWork: Fiber,
committedLanes: Lanes,
// This function visits both newly finished work and nodes that were re-used
// from a previously committed tree. We cannot check non-static flags if the
// node was reused.
Expand All @@ -2719,7 +2717,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
// TODO: Check flags & LayoutStatic
Expand All @@ -2730,7 +2727,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);

Expand Down Expand Up @@ -2772,7 +2768,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);

Expand All @@ -2792,7 +2787,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
// TODO: Figure out how Profiler updates should work with Offscreen
Expand All @@ -2805,7 +2799,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);

Expand All @@ -2825,7 +2818,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
}
Expand All @@ -2835,7 +2827,6 @@ function reappearLayoutEffects(
recursivelyTraverseReappearLayoutEffects(
finishedRoot,
finishedWork,
committedLanes,
includeWorkInProgressEffects,
);
break;
Expand All @@ -2846,7 +2837,6 @@ function reappearLayoutEffects(
function recursivelyTraverseReappearLayoutEffects(
finishedRoot: FiberRoot,
parentFiber: Fiber,
committedLanes: Lanes,
includeWorkInProgressEffects: boolean,
) {
// This function visits both newly finished work and nodes that were re-used
Expand All @@ -2865,7 +2855,6 @@ function recursivelyTraverseReappearLayoutEffects(
finishedRoot,
current,
child,
committedLanes,
childShouldIncludeWorkInProgressEffects,
);
child = child.sibling;
Expand Down

0 comments on commit 7bcc687

Please sign in to comment.