Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking radios fires a change event unconditionally in older browsers #11560

Closed
nhunzaker opened this issue Nov 15, 2017 · 5 comments
Closed
Labels

Comments

@nhunzaker
Copy link
Contributor

This may be a change we agreed to that I missed, but the "Radio input clicks" test fixtures fails in:

Safari 7.1, 8, 9
iOS Safari 8.4
Chrome 42

The test fixture is here:
http://react-dom-test-fixtures.surge.sh/input-change-events

Do we care about this? If not, we should figure out a way to document this.

@nhunzaker
Copy link
Contributor Author

cc @jquense @aweary, but no rush :)

@aweary
Copy link
Contributor

aweary commented Nov 16, 2017

Are those browser versions supported? cc @sophiebits. If so, we should probably fix it but otherwise, we can ignore it 😄

I'm guessing those Safari versions are probably still supported.

@stale
Copy link

stale bot commented Jan 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 10, 2020
@stale
Copy link

stale bot commented Jan 19, 2020

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@stale stale bot closed this as completed Jan 19, 2020
@gaearon
Copy link
Collaborator

gaearon commented Apr 1, 2020

Over-firing is ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants