tests: add regression test for reading ReactCurrentOwner stateNode #12412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe something like this @gaearon? |
gaearon
reviewed
Mar 21, 2018
| expect(() => { | ||
| ReactDOM.render(<App />, container); | ||
| }).not.toThrow(stateNodeErr); | ||
| } |
There was a problem hiding this comment.
It's enough to replace this whole block with just ReactDOM.render(<App />, container). If it did throw, the test would fail anyway. You can remove the error declaration too.
gaearon
reviewed
Mar 21, 2018
| @@ -377,6 +377,26 @@ describe('ReactDOM', () => { | |||
| } | |||
| }); | |||
|
|
|||
| it('should not throw a TypeError when reading stateNode on ReactCurrentOwner', () => { | |||
There was a problem hiding this comment.
We avoid implementation details in test titles. Just "should not crash calling findDOMNode inside a functional component".
|
Updated. |
This was referenced Apr 17, 2018
This was referenced Apr 19, 2018
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
…acebook#12412) * tests: add regression test for reading ReactCurrentOwner stateNode * tests: replace expect with just rendering the component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR for #12407. Adds a regression test related to issue #12299.
Before the #12407 fix this test case would fail as: