Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools Profiler: "Could not find commit data for root …" #18010

Closed
bvaughn opened this issue Feb 10, 2020 · 10 comments · Fixed by #18880
Closed

DevTools Profiler: "Could not find commit data for root …" #18010

bvaughn opened this issue Feb 10, 2020 · 10 comments · Fixed by #18880

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Feb 10, 2020

The DevTools Profiler occasionally encounters the error:

Could not find commit data for root "..." and commit ...

This issue is intermittent and we do not currently know hot to reproduce it. If you can reproduce it we would love to get any of the following information from you:

  • Info about how you reproduce it. (Share your code or site with us?)
  • An exported Profiler JSON that contains the bug. (This may be less useful, since the bug likely happens pre-export- but may still be helpful.)
@esvyridov
Copy link

@bvaughn Hi. During my investigation I reproduced the issue a couple of times using storybook.
Here is a link to sandbox https://codesandbox.io/s/react-devtools-profiler-error-7q1ml

Steps to reproduce:

  1. Open codesandbox browser window in a separate tab (https://7q1ml.sse.codesandbox.io/?path=/story/button--with-text)
  2. Start to record in Profiler
  3. Select Button with text
  4. Select Button with emoji
  5. Stop recording
  6. Select the lowest row in the Profiler
  7. Select button instead of Root in Profiler

Please check a gif:
ezgif-3-56a7e856f928

And json:
profiling-data.02-14-2020.17-37-05.json.zip

@bvaughn
Copy link
Contributor Author

bvaughn commented Feb 14, 2020

Thanks for the info, @esvyridov!

@ghost
Copy link

ghost commented Feb 14, 2020

Hi @bvaughn , I'm interested in working on this.

@bvaughn
Copy link
Contributor Author

bvaughn commented Feb 14, 2020

Dive on in then, @peanutenthusiast. 😄

I've added the "good first issue (taken)" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

@ghost
Copy link

ghost commented Feb 14, 2020

Cheers! 🎊

@ghost
Copy link

ghost commented Feb 27, 2020

heads up was a little sick the past couple of weeks but will be looking into getting a pr in by end of week

@bvaughn bvaughn changed the title Bug: DevTools Profiler "Could not find commit data for root..." DevTools Profiler: "Could not find commit data for root …" Mar 4, 2020
@bvaughn
Copy link
Contributor Author

bvaughn commented Mar 25, 2020

Hi @peanutenthusiast!

Just checking in to see if you're still interested in working on this. If not, that's okay! Just let us know though so we can update the labels if needed.

@ghost
Copy link

ghost commented Mar 25, 2020

YES I AM.

@bvaughn
Copy link
Contributor Author

bvaughn commented Mar 25, 2020

Okay 😄 I suggest rebasing on master so you'll get the change from bd57819. It does not fix this issue, but it does rule out one potential source of error.

@ghost
Copy link

ghost commented Mar 25, 2020

excellent. will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants