-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested code cleanup: Update all old https://facebook.github.io and https://github.com/facebookincubator/create-react-app links #19947
Comments
Feel free to send a PR, @sktguha |
Sure, Thanks @bvaughn . Any order of priority? Like Readme should be done first? |
No priority. |
ok, got it. Thank you. |
@bvaughn I have started work on this. You can see progress on this branch: https://github.com/sktguha/react/tree/update-outdated-links Btw should I go ahead and create a PR from this and you can review and merge if ok ? As for the other one, i.e updating facebookincubator/create-react-app links , it is bit too long, thus it may turn out to be a big PR if combined at once. Also I have found some more issues in the codebase and raised another issue regarding them : #19978. Please take a look, if you get time. |
One PR or two. It's up to you. When you're ready, just post it and one of us will review it when we get the chance. |
Closing this as this has been fixed by the merge of the above linked PR made by me |
So I suggest replacing the links to https://facebook.github.io and https://github.com/facebookincubator/create-react-app with the correct updated links.
Yes I understand that redirects are setup properly, so there is no broken links but still it is much cleaner if they had the updated links. For example seeing the old link, a person might go to https://github.com/facebookincubator to find some other important projects there, but of course the important projects like flow type checker etc, are at https://github.com/facebook instead
I think atleast for some places like Readme(these old links are there in some Readme files) it should definitely be done, if not all places
If so, I want to volunteer for this effort. Please assign this issue to me in that case
Here is a search for these two links in the codebase:
https://github.com/facebook/react/search?q=https%3A%2F%2Fgithub.com%2Ffacebookincubator%2Fcreate-react-app
https://github.com/facebook/react/search?q=%22facebook.github.io%22
The text was updated successfully, but these errors were encountered: