Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Fix Circle CI to run all DevTools tests #21780

Closed
bvaughn opened this issue Jul 1, 2021 · 5 comments
Closed

[DevTools] Fix Circle CI to run all DevTools tests #21780

bvaughn opened this issue Jul 1, 2021 · 5 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Jul 1, 2021

Circle CI only runs some of the DevTools tests, e.g.
https://app.circleci.com/pipelines/github/facebook/react/15329/workflows/8547df20-d3cd-4795-b2f0-a4bbe9e39a9e/jobs/336119

Run locally:
Screen Shot 2021-07-01 at 11 30 25 AM

Run on CI:
Screen Shot 2021-07-01 at 11 29 59 AM

Presumably there's something wrong with our CircleCI config file or one of the Jest configuration files elsewhere.

@houssemchebeb
Copy link
Contributor

houssemchebeb commented Jul 1, 2021

@bvaughn Can i take this one ?

@bvaughn
Copy link
Contributor Author

bvaughn commented Jul 1, 2021

@houssemchebeb This issue is all yours! 😄

I've added the "good first issue (taken)" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

@houssemchebeb
Copy link
Contributor

houssemchebeb commented Jul 1, 2021

Ok thanks!

@leogiertz
Copy link

I believe that it already runs all of the tests but split among several different containers.

Check here:
https://app.circleci.com/pipelines/github/facebook/react/15400/workflows/9ba94cb2-cbb6-4351-9f40-aad74171168c/jobs/337002/parallel-runs/0?filterBy=ALL

Screenshot 2021-07-02 at 00 51 59
Screenshot 2021-07-02 at 00 51 44

@bvaughn
Copy link
Contributor Author

bvaughn commented Jul 2, 2021

Oooh, I believe you're right. I wasn't reading the Circle CI UI correctly. So DevTools tests are broken into 20 parallel containers, each one running only a couple of tests.

That makes sense! I think we can close this issue then as my mistake 😁

@bvaughn bvaughn closed this as completed Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants