Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark alternative source-map parsing library #22116

Closed
bvaughn opened this issue Aug 17, 2021 · 3 comments
Closed

Benchmark alternative source-map parsing library #22116

bvaughn opened this issue Aug 17, 2021 · 3 comments
Assignees
Labels
Component: Developer Tools Resolution: Stale Automatically closed due to inactivity

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Aug 17, 2021

The "named hooks" feature uses the source-map library to parse source maps. We should check out the 'source-map-js' fork. (Supposedly it's a lot faster.)

Let's benchmark the two and see if it speeds us up too?

@bvaughn
Copy link
Contributor Author

bvaughn commented Aug 18, 2021

I took a look at this using some Facebook components and here are the results.

Parsing hooks for component A:

  • source-map: 1726 ms
  • source-map-js: 1772.5 ms

Parsing hooks for component B:

  • source-map: 4627.3 ms
  • source-map-js: 4198.8 ms

Still warrants more testing as this was very ad hoc, but initially the results don't seem that compelling.

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the Resolution: Stale Automatically closed due to inactivity label Jan 9, 2022
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Developer Tools Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

No branches or pull requests

1 participant