Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools Bug]: "Reload and start profiling" button is missing on Microsoft Edge #22630

Closed
yifanwww opened this issue Oct 26, 2021 · 6 comments
Closed
Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug

Comments

@yifanwww
Copy link

Website or app

Any development URL are ok

Repro steps

  1. Open the React Developer Tools extension on Chrome and navigate to the Profiler tab. Note the presence of the "Reload and start profiling" button.
  2. Open the React Developer Tools extension on Microsoft Edge and navigate to the Profiler tab. Note the absence of this button.

I have checked #21384, and document.featurePolicy.allowsFeature('sync-xhr') returns true.

How often does this bug happen?

Every time

DevTools package (automated)

No response

DevTools version (automated)

4.20.2

Error message (automated)

No response

Error call stack (automated)

No response

Error component stack (automated)

No response

GitHub query string (automated)

No response

@yifanwww yifanwww added Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug labels Oct 26, 2021
@eoandersson
Copy link
Contributor

eoandersson commented Oct 26, 2021

From what I can gather, in React this feature is currently only enabled for the Chrome extension, see here: https://github.com/facebook/react/blob/main/packages/react-devtools-extensions/src/main.js#L206

If this is something that should be included for the Edge extension as well I'd be happy to work on this issue.

@bvaughn
Copy link
Contributor

bvaughn commented Oct 26, 2021

@eoandersson It was originally enabled for Chrome only because Firefox didn't work with the feature. If you are willing to test and verify that Edge supports the feature (which it probably does, since it's Chromium too) then I'd be happy to accept a PR.

@eoandersson
Copy link
Contributor

@bvaughn As far as I can tell, the feature works identically in Edge after enabling it, so I created a PR for it: #22631.

@bvaughn bvaughn closed this as completed Oct 27, 2021
@yifanwww
Copy link
Author

@eoandersson Hi I notice that in this commit 26bc8ff, your PR seems to have also been reverted.

See 26bc8ff#diff-2c5e1f5e80e74154e65b2813cf1c3638f85034530e99dae24809ab4ad70d0143R150-L212

@bvaughn
Copy link
Contributor

bvaughn commented Oct 28, 2021

Thanks for spotting this, @yifanwww. Seems unintentional.

cc @jstejada Looks like the revert commit pulled in more than it should have

@torressam333
Copy link

I don't see it in chrome now either using chrome 120 and DevTools v5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Developer Tools Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug Type: Bug
Projects
None yet
Development

No branches or pull requests

4 participants