Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some attributes are only set if SSR is used #5966

Closed
jimfb opened this issue Feb 2, 2016 · 2 comments
Closed

some attributes are only set if SSR is used #5966

jimfb opened this issue Feb 2, 2016 · 2 comments

Comments

@jimfb
Copy link
Contributor

jimfb commented Feb 2, 2016

Maybe we don't care, but some attributes are currently only set if SSR is used.

http://jsfiddle.net/8ftyu8eq/

Not sure if it's worse than the old behavior (which was different for initial render as compared to subsequent renders). But this could be a tricky one for people to debug if they hit it, since it depends on a more subtle difference (SSR vs CSR); I imagine people frequently fail to test their components on SSR, so the difference is more likely to catch them by surprise.

@zpao
Copy link
Member

zpao commented Feb 2, 2016

CSS selectors use the DOM attribute. Now that we aren't generating the markup and inserting, initial values are also set the same way that they were for updates. value uses the property, not the attribute. Unless everything is set via the attribute (which isn't 100% possible) then we'll need to have some cases that aren't possible to catch. But we could potentially start using attributes for everything that is possible. cc @spicyj

@sophiebits
Copy link
Contributor

For value, this is essentially a dupe of #4618.

Gonna call style a wontfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants