Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run at least a subset of the tests in-browser before releases #6248

Closed
quantizor opened this issue Mar 11, 2016 · 4 comments
Closed

Run at least a subset of the tests in-browser before releases #6248

quantizor opened this issue Mar 11, 2016 · 4 comments

Comments

@quantizor
Copy link
Contributor

Frankly, it scares me a little that a substantial IE text node bug made it through into a release candidate. Some of the tests could fairly easily be run on SauceLabs or a similar service to do actual browser verification.

@iamdustan
Copy link
Contributor

Is this not precisely what prereleases are for? To capture bugs that unit tests and the team has missed in development?

@gaearon
Copy link
Collaborator

gaearon commented Mar 11, 2016

This is definitely something we want to do.
Please refer to #5703 for the related discussion.
I’m not sure what the specific roadblocks are, but it’s better to ask in the existing issue.

@gaearon gaearon closed this as completed Mar 11, 2016
@quantizor
Copy link
Contributor Author

@iamdustan absolutely not. Relying on the community to catch core bugs is ludicrous

@zpao
Copy link
Member

zpao commented Mar 11, 2016

Yea, this was a bad one that got through. We should have caught it. There are a couple things we could do differently for that particular one (including but not limited to browser testing). Thanks for bringing it up - it's definitely on our minds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants