-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New DOM renderer inserts parameters after creation on IE #6629
Comments
If an object gets created when the |
Just checked, that is what's causing it. |
This applies to all parameters it seems, making flash virtually unusable with React 15. |
That seems reasonable. The fact that this took weeks to be reported suggests to me that few people are in this situation. Were you not able to get your patch #6640 to work? Why not? |
@spicyj Yeah, I would assume object and/or flash is very rarely used nowadays, especially in React.
Slight misunderstanding of how DOMLazyTree works, I also saw that such a special-case was already present for document fragments and I simply added |
Released. |
The new renderer is causing Flash objects to be instantiated before any nested param nodes have been added, they are read and parsed at creation and never touched again. EDIT: I'm assuming the Flash object is loaded immediately upon insertion into the DOM and not at the next tick.
This only happens on IE AFAIK (all versions including Edge). Related to the performance-special-case in the renderer?
cc @spicyj
The text was updated successfully, but these errors were encountered: