Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New DOM renderer inserts parameters after creation on IE #6629

Closed
syranide opened this issue Apr 27, 2016 · 6 comments
Closed

New DOM renderer inserts parameters after creation on IE #6629

syranide opened this issue Apr 27, 2016 · 6 comments

Comments

@syranide
Copy link
Contributor

syranide commented Apr 27, 2016

The new renderer is causing Flash objects to be instantiated before any nested param nodes have been added, they are read and parsed at creation and never touched again. EDIT: I'm assuming the Flash object is loaded immediately upon insertion into the DOM and not at the next tick.

This only happens on IE AFAIK (all versions including Edge). Related to the performance-special-case in the renderer?

cc @spicyj

@sophiebits
Copy link
Collaborator

If an object gets created when the object tag is appended to the document, then probably.

@syranide
Copy link
Contributor Author

Just checked, that is what's causing it.

@syranide syranide changed the title New DOM renderer does not work with FlashVars on IE New DOM renderer inserts parameters after creation on IE May 3, 2016
@syranide
Copy link
Contributor Author

syranide commented May 3, 2016

This applies to all parameters it seems, making flash virtually unusable with React 15.

@sophiebits
Copy link
Collaborator

That seems reasonable. The fact that this took weeks to be reported suggests to me that few people are in this situation. Were you not able to get your patch #6640 to work? Why not?

@syranide
Copy link
Contributor Author

syranide commented May 3, 2016

The fact that this took weeks to be reported suggests to me that few people are in this situation.

@spicyj Yeah, I would assume object and/or flash is very rarely used nowadays, especially in React.

Were you not able to get your patch #6640 to work? Why not?

Slight misunderstanding of how DOMLazyTree works, I also saw that such a special-case was already present for document fragments and I simply added <object> to that test. It now works as intended. #6691

@syranide
Copy link
Contributor Author

Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants