Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fiber] Spill-over from child reconciliation #7906

Closed
1 of 5 tasks
sebmarkbage opened this issue Oct 7, 2016 · 2 comments
Closed
1 of 5 tasks

[Fiber] Spill-over from child reconciliation #7906

sebmarkbage opened this issue Oct 7, 2016 · 2 comments

Comments

@sebmarkbage
Copy link
Collaborator

sebmarkbage commented Oct 7, 2016

This is spill-over from #7707 that I don't plan on doing in the initial batch.

  • Fix text node merging edge case... Search forward to find the next sibling, swap out the end of the text node to the sum of the previous value of the siblings. This trick lets us avoid back-references.
  • Have tag include children updated so that you can recalculate all children if needed. E.g. coroutines. Alternatively, pass the nearest host or coroutine down the tree so that it can be quickly flagged as child changed and insert/moves can be avoided to be added to the side-effect list for coroutines. The second option is probably better.
  • Possibly use two side-effect lists so that two passes are not needed and forward order is possible.
  • Remove the notion of output? Unnecessary extra traversal and requires duck typing to know which is terminal.
  • Reconsider if we need backpointers. There are several optimizations that are possible with them but uses more memory.
@gaearon
Copy link
Collaborator

gaearon commented Oct 4, 2017

Still relevant?

@NE-SmallTown
Copy link
Contributor

Could we comment the reason why close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants